Attachment 113330 Details for Bug 54445 – Add test for Windows SID (update)

[patch] Add test for Windows SID (update)

0003-Add-test-for-windows-sid.patch (text/plain), 2.48 KB, created by Ralf Habacker on 2015-02-10 22:51:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ralf Habacker

Created: 2015-02-10 22:51:17 UTC

Size: 2.48 KB

patch

obsolete

>From 2f02395fa1d94430f99b6a0a48a0eb1a5eb5ce6b Mon Sep 17 00:00:00 2001
>From: Ralf Habacker <ralf.habacker@freenet.de>
>Date: Tue, 10 Feb 2015 15:41:52 +0100
>Subject: [PATCH 3/5] Add test for windows sid.
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54445
>---
> dbus/dbus-sysdeps-win.c |  2 +-
> dbus/dbus-sysdeps-win.h |  1 +
> test/dbus-daemon.c      | 24 ++++++++++++++++++++++--
> 3 files changed, 24 insertions(+), 3 deletions(-)
>
>diff --git a/dbus/dbus-sysdeps-win.c b/dbus/dbus-sysdeps-win.c
>index dbd9043..526db8e 100644
>--- a/dbus/dbus-sysdeps-win.c
>+++ b/dbus/dbus-sysdeps-win.c
>@@ -984,7 +984,7 @@ static BOOL is_winxp_sp3_or_lower()
>  * @param process_id the process id for which the sid should be returned
>  * @returns process sid
>  */
>-static dbus_bool_t
>+dbus_bool_t
> _dbus_getsid(char **sid, dbus_pid_t process_id)
> {
>   HANDLE process_token = INVALID_HANDLE_VALUE;
>diff --git a/dbus/dbus-sysdeps-win.h b/dbus/dbus-sysdeps-win.h
>index 02e7a83..3efdf72 100644
>--- a/dbus/dbus-sysdeps-win.h
>+++ b/dbus/dbus-sysdeps-win.h
>@@ -88,6 +88,7 @@ dbus_bool_t _dbus_get_install_root(char *prefix, int len);
> void        _dbus_threads_windows_init_global (void);
> void        _dbus_threads_windows_ensure_ctor_linked (void);
> 
>+dbus_bool_t _dbus_getsid(char **sid, dbus_pid_t process_id);
> #endif
> 
> /** @} end of sysdeps-win.h */
>diff --git a/test/dbus-daemon.c b/test/dbus-daemon.c
>index 6b0e9b8..4516091 100644
>--- a/test/dbus-daemon.c
>+++ b/test/dbus-daemon.c
>@@ -371,6 +371,28 @@ test_creds (Fixture *f,
>           g_assert_not_reached ();
> #endif
>         }
>+      else if (g_strcmp0 (name, "WindowsSID") == 0)
>+        {
>+#ifdef G_OS_WIN32
>+          gchar *sid;
>+          guint32 result;
>+          char *self_sid;
>+
>+          g_assert (!(seen & SEEN_WINDOWS_SID));
>+          g_assert_cmpuint (dbus_message_iter_get_arg_type (&var_iter), ==,
>+              DBUS_TYPE_STRING);
>+          dbus_message_iter_get_basic (&var_iter, &sid);
>+          g_message ("%s of this process is %s", name, sid);
>+          if (_dbus_getsid (&self_sid, 0))
>+            {
>+              g_assert_cmpstr (self_sid, ==, sid);
>+              LocalFree(self_sid);
>+            }
>+          seen |= SEEN_WINDOWS_SID;
>+#else
>+          g_assert_not_reached ();
>+#endif
>+        }
>       else if (g_strcmp0 (name, "ProcessID") == 0)
>         {
>           guint32 u32;
>@@ -402,9 +424,7 @@ test_creds (Fixture *f,
> #endif
> 
> #ifdef G_OS_WIN32
>-  /* FIXME: when implemented:
>   g_assert (seen & SEEN_WINDOWS_SID);
>-   */
> #endif
> }
> 
>-- 
>1.8.4.5
>

Actions: View | Splinter Review

Attachments on bug 54445: 66552 | 66554 | 66555 | 66559 | 66569 | 66578 | 66626 | 66629 | 66741 | 75650 | 75651 | 75652 | 75653 | 75654 | 75689 | 76017 | 76018 | 81340 | 81341 | 81342 | 81389 | 82573 | 82643 | 84562 | 84801 | 84802 | 84804 | 113318 | 113319 | 113321 | 113330 | 113360

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.