Attachment 113654 Details for Bug 73378 – Possible fix

[patch] Possible fix

0001-drm-radeon-drop-setting-UPLL-to-sleep-mode.patch (text/plain), 1.51 KB, created by Christian König on 2015-02-19 08:43:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Christian König

Created: 2015-02-19 08:43:52 UTC

Size: 1.51 KB

patch

obsolete

>From fd9cb1550d9a46ce1e6b4d9ba99ab4ccdfce87cc Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>
>Date: Thu, 19 Feb 2015 09:40:28 +0100
>Subject: [PATCH] drm/radeon: drop setting UPLL to sleep mode
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Just keep it working, seems to fix some PLL problems.
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=73378
>
>Signed-off-by: Christian KÃ¶nig <christian.koenig@amd.com>
>---
> drivers/gpu/drm/radeon/si.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/si.c b/drivers/gpu/drm/radeon/si.c
>index f34d281..b9caafa 100644
>--- a/drivers/gpu/drm/radeon/si.c
>+++ b/drivers/gpu/drm/radeon/si.c
>@@ -7126,8 +7126,7 @@ int si_set_uvd_clocks(struct radeon_device *rdev, u32 vclk, u32 dclk)
> 	WREG32_P(CG_UPLL_FUNC_CNTL, UPLL_BYPASS_EN_MASK, ~UPLL_BYPASS_EN_MASK);
> 
> 	if (!vclk || !dclk) {
>-		/* keep the Bypass mode, put PLL to sleep */
>-		WREG32_P(CG_UPLL_FUNC_CNTL, UPLL_SLEEP_MASK, ~UPLL_SLEEP_MASK);
>+		/* keep the Bypass mode */
> 		return 0;
> 	}
> 
>@@ -7143,8 +7142,7 @@ int si_set_uvd_clocks(struct radeon_device *rdev, u32 vclk, u32 dclk)
> 	/* set VCO_MODE to 1 */
> 	WREG32_P(CG_UPLL_FUNC_CNTL, UPLL_VCO_MODE_MASK, ~UPLL_VCO_MODE_MASK);
> 
>-	/* toggle UPLL_SLEEP to 1 then back to 0 */
>-	WREG32_P(CG_UPLL_FUNC_CNTL, UPLL_SLEEP_MASK, ~UPLL_SLEEP_MASK);
>+	/* disable sleep mode */
> 	WREG32_P(CG_UPLL_FUNC_CNTL, 0, ~UPLL_SLEEP_MASK);
> 
> 	/* deassert UPLL_RESET */
>-- 
>1.9.1
>

Actions: View | Splinter Review

Attachments on bug 73378: 91631 | 96253 | 107749 | 107750 | 111366 | 113544 | 113654

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.