Attachment 113825 Details for Bug 89034 – Possible fix

[patch] Possible fix

0001-radeonsi-Pad-image-offset-vectors-with-zero-instead-.patch (text/plain), 1.41 KB, created by Tom Stellard on 2015-02-25 17:52:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tom Stellard

Created: 2015-02-25 17:52:57 UTC

Size: 1.41 KB

patch

obsolete

>From e58af862f4bf5e16c191198a62b55c24b19a762f Mon Sep 17 00:00:00 2001
>From: Tom Stellard <thomas.stellard@amd.com>
>Date: Wed, 25 Feb 2015 11:44:59 -0500
>Subject: [PATCH] radeonsi: Pad image offset vectors with zero instead of undef
>
>undef is interpreted as 'any value', so it is better to use a constant
>like zero, because we can be sure that the behavior of the instruction
>will always be the same.
>---
> src/gallium/drivers/radeonsi/si_shader.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c
>index 0ddb806..9698dbe 100644
>--- a/src/gallium/drivers/radeonsi/si_shader.c
>+++ b/src/gallium/drivers/radeonsi/si_shader.c
>@@ -1703,7 +1703,7 @@ static void tex_fetch_args(
> 
> 		/* Pad to a power-of-two size. */
> 		while (txf_count < util_next_power_of_two(txf_count))
>-			txf_address[txf_count++] = LLVMGetUndef(LLVMInt32TypeInContext(gallivm->context));
>+			txf_address[txf_count++] = bld_base->uint_bld.zero;
> 
> 		/* Read FMASK using TXF. */
> 		inst.Instruction.Opcode = TGSI_OPCODE_TXF;
>@@ -1880,7 +1880,7 @@ static void tex_fetch_args(
> 
> 	/* Pad to power of two vector */
> 	while (count < util_next_power_of_two(count))
>-		address[count++] = LLVMGetUndef(LLVMInt32TypeInContext(gallivm->context));
>+		address[count++] = bld_base->uint_bld.zero;
> 
> 	emit_data->args[0] = lp_build_gather_values(gallivm, address, count);
> }
>-- 
>1.8.5.5
>

Actions: View | Splinter Review

Attachments on bug 89034: 113269 | 113272 | 113309 | 113310 | 113343 | 113344 | 113709 | 113715 | 113716 | 113809 | 113810 | 113825 | 113826 | 114561

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.