Attachment 113837 Details for Bug 87637 – Refinement of the /P annotation test

[patch] Refinement of the /P annotation test

87637.patch (text/plain), 1.23 KB, created by Thomas Freitag on 2015-02-26 08:37:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Freitag

Created: 2015-02-26 08:37:59 UTC

Size: 1.23 KB

patch

obsolete

>diff --git a/poppler/PDFDoc.cc b/poppler/PDFDoc.cc
>index 71a1efe..76d0156 100644
>--- a/poppler/PDFDoc.cc
>+++ b/poppler/PDFDoc.cc
>@@ -1612,10 +1612,27 @@ GBool PDFDoc::markAnnotations(Object *annotsObj, XRef *xRef, XRef *countRef, Gui
>                 type.free();
>                 continue;
>               } else {
>-                array->remove(i);
>+                Object page;
>+                getXRef()->fetch(obj2.getRef().num, obj2.getRef().gen, &page);
>+                if (page.isDict()) {
>+                  Object pagetype;
>+                  Dict *dict = page.getDict();
>+                  dict->lookup("Type", &pagetype);
>+                  if (!pagetype.isName() || strcmp(pagetype.getName(), "Page") != 0) {
>+                    obj1.free();
>+                    obj2.free();
>+                    type.free();
>+                    page.free();
>+                    pagetype.free();
>+                    continue;
>+                  }                  
>+                  pagetype.free();
>+                }
>+                page.free();
>                 obj1.free();
>                 obj2.free();
>                 type.free();
>+                array->remove(i);
>                 modified = gTrue;
>                 continue;
>               }

Actions: View | Splinter Review

Attachments on bug 87637: 111220 | 111850 | 113165 | 113535 | 113803 | 113837 | 118096 | 121505 | 121536 | 121586 | 122326

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.