Attachment 113957 Details for Bug 89284 – Fix warning: conversion to 'DWORD' from 'int' may change the sign of the result [-Wsign-conversion].

[patch] Fix warning: conversion to 'DWORD' from 'int' may change the sign of the result [-Wsign-conversion].

0001-Fix-warning-conversion-to-DWORD-from-int-may-change-th.txt (text/plain), 1.24 KB, created by Ralf Habacker on 2015-03-03 16:18:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ralf Habacker

Created: 2015-03-03 16:18:11 UTC

Size: 1.24 KB

patch

obsolete

>From 94850688792b4c0978da36cd2b2d9d3d29039204 Mon Sep 17 00:00:00 2001
>From: Ralf Habacker <ralf.habacker@freenet.de>
>Date: Tue, 3 Mar 2015 17:16:51 +0100
>Subject: [PATCH] Fix warning: conversion to 'DWORD' from 'int' may change the
> sign of the result [-Wsign-conversion].
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=17289
>---
> tools/tool-common.c | 2 +-
> tools/tool-common.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/tools/tool-common.c b/tools/tool-common.c
>index 16c7956..1204ee2 100644
>--- a/tools/tool-common.c
>+++ b/tools/tool-common.c
>@@ -40,7 +40,7 @@
> /* a hack to avoid having to depend on the static -util version of libdbus;
>  * it's useful for ancillary programs to be able to use the shared library */
> void
>-tool_millisleep (int ms)
>+tool_millisleep (unsigned int ms)
> {
> #ifdef DBUS_WIN
>   Sleep (ms);
>diff --git a/tools/tool-common.h b/tools/tool-common.h
>index c598482..8659011 100644
>--- a/tools/tool-common.h
>+++ b/tools/tool-common.h
>@@ -32,7 +32,7 @@
> #define VERBOSE(...) do {} while (0)
> #endif
> 
>-void tool_millisleep (int ms);
>+void tool_millisleep (unsigned int ms);
> void tool_oom (const char *doing) _DBUS_GNUC_NORETURN;
> dbus_bool_t tool_write_all (int fd, const void *buf, size_t size);
> 
>-- 
>1.8.4.5
>

Actions: View | Splinter Review

Attachments on bug 89284: 113763 | 113808 | 113814 | 113842 | 113946 | 113953 | 113956 | 113957 | 113958 | 113976 | 113977 | 113978 | 113980 | 113985 | 113987

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.