Attachment 113992 Details for Bug 17289 – [4/5] Autotools: enable -Wsign-compare and optionally -Werror=sign-compare

[patch] [4/5] Autotools: enable -Wsign-compare and optionally -Werror=sign-compare

0004-Autotools-enable-Wsign-compare-and-optionally-Werror.patch (text/plain), 1.03 KB, created by Simon McVittie on 2015-03-04 11:41:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2015-03-04 11:41:16 UTC

Size: 1.03 KB

patch

obsolete

>From ef892a8ea7afedf6f762102b2777e8320d5bba5a Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Wed, 4 Mar 2015 10:41:47 +0000
>Subject: [PATCH 4/5] Autotools: enable -Wsign-compare and optionally
> -Werror=sign-compare
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=17289
>---
> configure.ac | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/configure.ac b/configure.ac
>index 5f78d19..7443ae7 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -1362,13 +1362,12 @@ TP_COMPILER_WARNINGS([WARNING_CFLAGS],
>   dnl - unused-parameter is to make writing callbacks less annoying
>   dnl
>   dnl To be fixed one day:
>-  dnl - sign-compare and pointer-sign are workarounds for fd.o #17433
>+  dnl - pointer-sign is a workaround for fd.o #15522
>   dnl - type-limits is probably a bug too, but having the rest of -Wextra
>   dnl   is better than nothing
>   [$DISABLE_UNUSED_WARNINGS \
>    missing-field-initializers \
>    unused-parameter \
>-   sign-compare \
>    pointer-sign \
>    type-limits \
>   ])
>-- 
>2.1.4
>

Actions: View | Splinter Review

Attachments on bug 17289: 18494 | 18495 | 113960 | 113966 | 113983 | 113984 | 113988 | 113989 | 113990 | 113991 | 113992 | 113993 | 113994 | 113996 | 114001 | 114002

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.