Attachment 113993 Details for Bug 17289 – [6] signal_handler: avoid signed/unsigned mismatch (-Wsign-compare)

[patch] [6] signal_handler: avoid signed/unsigned mismatch (-Wsign-compare)

0006-signal_handler-avoid-signed-unsigned-mismatch-Wsign-.patch (text/plain), 1.48 KB, created by Simon McVittie on 2015-03-04 11:57:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2015-03-04 11:57:11 UTC

Size: 1.48 KB

patch

obsolete

>From 4314bacc3f576958bda880d54b10fd81409a2121 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Wed, 4 Mar 2015 11:52:51 +0000
>Subject: [PATCH 6/7] signal_handler: avoid signed/unsigned mismatch
> (-Wsign-compare)
>
>We're ignoring the result of this write() to stderr anyway, because
>if it failed... what would we do? Write to stderr? That wouldn't work
>any better the second time :-)
>---
> bus/main.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/bus/main.c b/bus/main.c
>index b48f03f..ad02b97 100644
>--- a/bus/main.c
>+++ b/bus/main.c
>@@ -87,7 +87,8 @@ signal_handler (int sig)
>             static const char message[] =
>               "Unable to write to reload pipe - buffer full?\n";
> 
>-            if (write (STDERR_FILENO, message, strlen (message)) != strlen (message))
>+            if (write (STDERR_FILENO, message, strlen (message)) !=
>+                (ssize_t) strlen (message))
>               {
>                 /* ignore failure to write out a warning */
>               }
>@@ -111,7 +112,8 @@ signal_handler (int sig)
>               "Unable to write termination signal to pipe - buffer full?\n"
>               "Will exit instead.\n";
> 
>-            if (write (STDERR_FILENO, message, strlen (message)) != strlen (message))
>+            if (write (STDERR_FILENO, message, strlen (message)) !=
>+                (ssize_t) strlen (message))
>               {
>                 /* ignore failure to write out a warning */
>               }
>-- 
>2.1.4
>

Actions: View | Splinter Review

Attachments on bug 17289: 18494 | 18495 | 113960 | 113966 | 113983 | 113984 | 113988 | 113989 | 113990 | 113991 | 113992 | 113993 | 113994 | 113996 | 114001 | 114002

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.