Attachment 114210 Details for Bug 89502 – Version 2 - Only a minor cleanup of ProfileData

Version 2 - Only a minor cleanup of ProfileData

poppler-profiledata-v2.patch (text/plain), 1.15 KB, created by Kurt Schwehr on 2015-03-10 21:23:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kurt Schwehr

Created: 2015-03-10 21:23:44 UTC

Size: 1.15 KB

patch

obsolete

>--- poppler-0.32.0/poppler/Gfx.cc	2015-02-09 13:30:14.000000000 -0800
>+++ poppler/poppler/Gfx.cc	2015-03-09 20:23:28.425669711 -0700
>@@ -766,18 +766,16 @@
>       if (profileCommands) {
> 	GooHash *hash;
> 
>-	hash = out->getProfileHash ();
>+	hash = out->getProfileHash();
> 	if (hash) {
>-	  GooString *cmd_g;
>-	  ProfileData *data_p;
>+	  GooString *cmd_g = new GooString (obj.getCmd());;
>+	  ProfileData *data_p = (ProfileData *)hash->lookup(cmd_g);;
> 
>-	  cmd_g = new GooString (obj.getCmd());
>-	  data_p = (ProfileData *)hash->lookup (cmd_g);
> 	  if (data_p == NULL) {
> 	    data_p = new ProfileData();
> 	    hash->add (cmd_g, data_p);
> 	  }
>-	  
>+
> 	  data_p->addElement(timer.getElapsed ());
> 	}
>       }
>--- poppler-0.32.0/poppler/ProfileData.cc	2012-12-27 16:17:03.000000000 -0800
>+++ poppler/poppler/ProfileData.cc	2015-03-10 14:17:42.344365011 -0700
>@@ -20,12 +20,7 @@
> // ProfileData
> //------------------------------------------------------------------------
> 
>-ProfileData::ProfileData() {
>-	count = 0;
>-	total = 0.0;
>-	min = 0.0;
>-	max = 0.0;
>-}
>+ProfileData::ProfileData() : count(0), total(0.0), min(0.0), max(0.0) {}
> 
> void
> ProfileData::addElement (double elapsed) {

Actions: View

Attachments on bug 89502: 114163 | 114210

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.