Attachment 114483 Details for Bug 87347 – avoid spurious PM interrupts

[patch] avoid spurious PM interrupts

0001-drm-i915-gen6-avoid-spurious-rps-interrupts.patch (text/plain), 1.17 KB, created by Imre Deak on 2015-03-19 21:54:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Imre Deak

Created: 2015-03-19 21:54:58 UTC

Size: 1.17 KB

patch

obsolete

>From cd835d48d77fdb7e368ccf6c490126ef8342f065 Mon Sep 17 00:00:00 2001
>From: Imre Deak <imre.deak@intel.com>
>Date: Thu, 19 Mar 2015 21:08:53 +0200
>Subject: [PATCH] drm/i915/gen6+: avoid spurious rps interrupts
>
>Signed-off-by: Imre Deak <imre.deak@intel.com>
>---
> drivers/gpu/drm/i915/i915_irq.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
>index 49ad5fb..9508a6b 100644
>--- a/drivers/gpu/drm/i915/i915_irq.c
>+++ b/drivers/gpu/drm/i915/i915_irq.c
>@@ -330,12 +330,15 @@ void gen6_disable_rps_interrupts(struct drm_device *dev)
> 	__gen6_disable_pm_irq(dev_priv, dev_priv->pm_rps_events);
> 	I915_WRITE(gen6_pm_ier(dev_priv), I915_READ(gen6_pm_ier(dev_priv)) &
> 				~dev_priv->pm_rps_events);
>-	I915_WRITE(gen6_pm_iir(dev_priv), dev_priv->pm_rps_events);
>-	I915_WRITE(gen6_pm_iir(dev_priv), dev_priv->pm_rps_events);
>-
>-	dev_priv->rps.pm_iir = 0;
> 
> 	spin_unlock_irq(&dev_priv->irq_lock);
>+
>+	synchronize_irq(dev->irq);
>+
>+	I915_WRITE(gen6_pm_iir(dev_priv), dev_priv->pm_rps_events);
>+	I915_WRITE(gen6_pm_iir(dev_priv), dev_priv->pm_rps_events);
>+
>+	dev_priv->rps.pm_iir = 0;
> }
> 
> /**
>-- 
>2.1.0
>

Actions: View | Splinter Review

Attachments on bug 87347: 110887 | 114483

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.