Attachment 114683 Details for Bug 89782 – service-client: Don't steal location ref

[patch] service-client: Don't steal location ref

service-client-Dont-steal-location-ref.patch (text/plain), 1.12 KB, created by Zeeshan Ali on 2015-03-28 15:56:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Zeeshan Ali

Created: 2015-03-28 15:56:03 UTC

Size: 1.12 KB

patch

obsolete

>From 8c5147232e079207d2092f9057d25007be2732b7 Mon Sep 17 00:00:00 2001
>From: "Zeeshan Ali (Khattak)" <zeeshanak@gnome.org>
>Date: Sat, 28 Mar 2015 15:50:58 +0000
>Subject: [PATCH] service-client: Don't steal location ref
>
>gclue_location_source_get_location() doesn't transfer ownership of the
>return location object so caller must add its own reference to it.
>
>This fixes the issue of 2nd app causing criticals warnings on geoclue's
>log and getting wrong and invalid location.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=89782
>---
> src/gclue-service-client.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/gclue-service-client.c b/src/gclue-service-client.c
>index fa00da6..9a1e834 100644
>--- a/src/gclue-service-client.c
>+++ b/src/gclue-service-client.c
>@@ -164,7 +164,7 @@ on_locator_location_changed (GObject    *gobject,
>         }
> 
>         g_clear_object (&priv->prev_location);
>-        priv->prev_location = priv->location;
>+        priv->prev_location = g_object_ref (priv->location);
> 
>         path = next_location_path (client);
>         priv->location = gclue_service_location_new (priv->client_info,
>-- 
>2.1.0

Actions: View | Splinter Review

Attachments on bug 89782: 114683 | 114784 | 114785 | 114786 | 114819

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.