Attachment 114727 Details for Bug 89734 – Possible fix

[patch] Possible fix

0001-drm-radeon-add-extra-check-in-radeon_ttm_tt_unpin_us.patch (text/plain), 1.14 KB, created by Christian König on 2015-03-30 13:12:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Christian König

Created: 2015-03-30 13:12:12 UTC

Size: 1.14 KB

patch

obsolete

>From 04030866b75af128cead82bdf8c76d1073e4f5d2 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>
>Date: Mon, 30 Mar 2015 15:10:24 +0200
>Subject: [PATCH] drm/radeon: add extra check in radeon_ttm_tt_unpin_userptr
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>We somehow try to free the SG table twice.
>
>Bugs: https://bugs.freedesktop.org/show_bug.cgi?id=89734
>
>Signed-off-by: Christian KÃ¶nig <christian.koenig@amd.com>
>---
> drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
>index d02aa1d..b292aca 100644
>--- a/drivers/gpu/drm/radeon/radeon_ttm.c
>+++ b/drivers/gpu/drm/radeon/radeon_ttm.c
>@@ -598,6 +598,10 @@ static void radeon_ttm_tt_unpin_userptr(struct ttm_tt *ttm)
> 	enum dma_data_direction direction = write ?
> 		DMA_BIDIRECTIONAL : DMA_TO_DEVICE;
> 
>+	/* double check that we don't free the table twice */
>+	if (!ttm->sg->sgl)
>+		return;
>+
> 	/* free the sg table and pages again */
> 	dma_unmap_sg(rdev->dev, ttm->sg->sgl, ttm->sg->nents, direction);
> 
>-- 
>1.9.1
>

Actions: View | Splinter Review

Attachments on bug 89734: 114584 | 114609 | 114670 | 114727 | 114820 | 114821 | 114841 | 114842

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.