Attachment 115068 Details for Bug 90021 – CID 54766: Resource leak (RESOURCE_LEAK).

[patch] CID 54766: Resource leak (RESOURCE_LEAK).

0001-CID-54766-Resource-leak-RESOURCE_LEAK.txt (text/plain), 1.64 KB, created by Ralf Habacker on 2015-04-14 08:03:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ralf Habacker

Created: 2015-04-14 08:03:52 UTC

Size: 1.64 KB

patch

obsolete

>From 13f0065dd0618cbabcb3267caae8efd1a2a53baa Mon Sep 17 00:00:00 2001
>From: Ralf Habacker <ralf.habacker@freenet.de>
>Date: Tue, 14 Apr 2015 10:01:49 +0200
>Subject: [PATCH] CID 54766: Resource leak (RESOURCE_LEAK).
>
>Variable original_argv going out of scope leaks the storage it points to.
>---
> test/shell-test.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/test/shell-test.c b/test/shell-test.c
>index d1dc5b5..87aa682 100644
>--- a/test/shell-test.c
>+++ b/test/shell-test.c
>@@ -52,6 +52,7 @@ test_command_line (const char *arg1, ...)
>   if (!_dbus_shell_parse_argv (command_line, &shell_argc, &shell_argv, &error))
>     {
>       fprintf (stderr, "Error parsing command line: %s\n", error.message ? error.message : "");
>+      dbus_free (original_argv);
>       return FALSE;
>     }
>   else
>@@ -60,6 +61,7 @@ test_command_line (const char *arg1, ...)
>         {
>           printf ("Number of arguments returned (%d) don't match original (%d)\n",
>                   shell_argc, original_argc);
>+          dbus_free (original_argv);
>           return FALSE;
>         } 
>       printf ("Number of arguments: %d\n", shell_argc);
>@@ -74,6 +76,7 @@ test_command_line (const char *arg1, ...)
>               printf ("Position %d, returned argument (%s) does not match original (%s)\n",
>                       i, shell_argv[i], unquoted);
>               dbus_free (unquoted);
>+              dbus_free (original_argv);
>               return FALSE;
>             }
>           dbus_free (unquoted);
>@@ -85,7 +88,8 @@ test_command_line (const char *arg1, ...)
>     }
>   
>   _dbus_string_free (&str);
>-  
>+  dbus_free (original_argv);
>+
>   return TRUE;
> }
> 
>-- 
>1.8.4.5
>

Actions: View | Splinter Review

Attachments on bug 90021: 115063 | 115064 | 115065 | 115068 | 115072 | 115073 | 115122 | 115234 | 115235 | 115236 | 115237 | 115246 | 115270 | 115576 | 115577 | 115578 | 115579 | 115580 | 115635 | 117015 | 119577 | 119578

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.