Attachment 115246 Details for Bug 90021 – test_command_line_internal: Fix variable original_argv going out of scope leaks the storage it points to (CID 60588)

[patch] test_command_line_internal: Fix variable original_argv going out of scope leaks the storage it points to (CID 60588)

0001-test_command_line_internal-Fix-variable-original_argv-.txt (text/plain), 1.04 KB, created by Ralf Habacker on 2015-04-21 12:15:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ralf Habacker

Created: 2015-04-21 12:15:31 UTC

Size: 1.04 KB

patch

obsolete

>From 305bdcf9781db910ee6a50e6cb8764f634d91e93 Mon Sep 17 00:00:00 2001
>From: Ralf Habacker <ralf.habacker@freenet.de>
>Date: Tue, 21 Apr 2015 14:14:26 +0200
>Subject: [PATCH] test_command_line_internal: Fix variable original_argv going
> out of scope leaks the storage it points to (CID 60588).
>
>Reported by Coverity: CID 60588: Resource leak (RESOURCE_LEAK)
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=90089
>Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
>---
> test/shell-test.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/test/shell-test.c b/test/shell-test.c
>index 1938379..61280d6 100644
>--- a/test/shell-test.c
>+++ b/test/shell-test.c
>@@ -93,15 +93,15 @@ test_command_line_internal (dbus_bool_t should_work,
>       dbus_free_string_array (shell_argv);
>     }
> 
>+  _dbus_string_free (&str);
>+  dbus_free (original_argv);
>+
>   if (!should_work)
>     {
>       printf ("# Expected an error\n");
>       return FALSE;
>     }
> 
>-  _dbus_string_free (&str);
>-  dbus_free (original_argv);
>-
>   return TRUE;
> }
> 
>-- 
>1.8.4.5
>

Actions: View | Splinter Review

Attachments on bug 90021: 115063 | 115064 | 115065 | 115068 | 115072 | 115073 | 115122 | 115234 | 115235 | 115236 | 115237 | 115246 | 115270 | 115576 | 115577 | 115578 | 115579 | 115580 | 115635 | 117015 | 119577 | 119578

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.