Attachment 115305 Details for Bug 89683 – [PATCH] touchpad: Only use slot 0 deltas for 2fg scrolling on semi-mt touchpads

[patch] [PATCH] touchpad: Only use slot 0 deltas for 2fg scrolling on semi-mt touchpads

0001-touchpad-Only-use-slot-0-deltas-for-2fg-scrolling-on.patch (text/plain), 1.47 KB, created by Hans de Goede on 2015-04-24 14:51:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Hans de Goede

Created: 2015-04-24 14:51:26 UTC

Size: 1.47 KB

patch

obsolete

>From 4cb88255a0c8e2c9bfc29c7176261487583fe12a Mon Sep 17 00:00:00 2001
>From: Hans de Goede <hdegoede@redhat.com>
>Date: Fri, 24 Apr 2015 16:18:24 +0200
>Subject: [PATCH] touchpad: Only use slot 0 deltas for 2fg scrolling on semi-mt
> touchpads
>
>Some semi-mt model touchpads have a better accuracy for slot 0 then for
>slot 1 (they only have 2), so on semi-mt models only use the movement of
>the touch in slot 0 for 2fg scrolling, rather then the average movement of
>the 2 touches.
>
>This fixes 2fg scrolling being choppy / jumpy in some cases.
>
>BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=89683
>Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>---
> src/evdev-mt-touchpad-gestures.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
>diff --git a/src/evdev-mt-touchpad-gestures.c b/src/evdev-mt-touchpad-gestures.c
>index d332186..57c07fe 100644
>--- a/src/evdev-mt-touchpad-gestures.c
>+++ b/src/evdev-mt-touchpad-gestures.c
>@@ -113,7 +113,17 @@ tp_gesture_post_twofinger_scroll(struct tp_dispatch *tp, uint64_t time)
> 	if (tp->scroll.method != LIBINPUT_CONFIG_SCROLL_2FG)
> 		return;
> 
>-	delta = tp_get_average_touches_delta(tp);
>+	/* On some semi-mt models slot 0 is more accurate, so for semi-mt
>+	 * we only use slot 0. */
>+	if (tp->semi_mt) {
>+		if (!tp->touches[0].dirty)
>+			return;
>+
>+		delta = tp_get_delta(&tp->touches[0]);
>+	} else {
>+		delta = tp_get_average_touches_delta(tp);
>+	}
>+
> 	delta = tp_filter_motion(tp, &delta, time);
> 
> 	if (normalized_is_zero(delta))
>-- 
>2.3.5
>

Actions: View | Splinter Review

Attachments on bug 89683: 114480 | 115264 | 115265 | 115266 | 115267 | 115305 | 115322

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.