Attachment 115326 Details for Bug 90175 – Fixes the bug

[patch] Fixes the bug

0001-glsl-properly-setting-var-data.binding-if-explicit_b.patch (text/plain), 1009 bytes, created by Alejandro Piñeiro (freenode IRC: apinheiro) on 2015-04-25 16:40:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alejandro Piñeiro (freenode IRC: apinheiro)

Created: 2015-04-25 16:40:52 UTC

Size: 1009 bytes

patch

obsolete

>From 07fe7a887345d173f019306760521d218c7f8290 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Alejandro=20Pi=C3=B1eiro?= <apinheiro@igalia.com>
>Date: Sat, 25 Apr 2015 14:43:52 +0200
>Subject: [PATCH] glsl: properly setting var->data.binding if explicit_binding
> is true
>
>There was a typo on commit c0cd5b, doing it when explicit_binding
>was false. This prevented to use any binding point different to 0.
>---
> src/glsl/link_atomics.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/glsl/link_atomics.cpp b/src/glsl/link_atomics.cpp
>index 603873a..9528e42 100644
>--- a/src/glsl/link_atomics.cpp
>+++ b/src/glsl/link_atomics.cpp
>@@ -201,7 +201,7 @@ link_assign_atomic_counter_resources(struct gl_context *ctx,
>          gl_uniform_storage *const storage = &prog->UniformStorage[id];
> 
>          mab.Uniforms[j] = id;
>-         if (!var->data.explicit_binding)
>+         if (var->data.explicit_binding)
>             var->data.binding = i;
> 
>          storage->atomic_buffer_index = i;
>-- 
>2.1.0
>

Actions: View | Splinter Review

Attachments on bug 90175: 115325 | 115326

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.