Attachment 115579 Details for Bug 90021 – do_check_nonce: Fix of calling _dbus_string_append_len without checking return value (CID 54720).

[patch] do_check_nonce: Fix of calling _dbus_string_append_len without checking return value (CID 54720).

0004-do_check_nonce-Fix-of-calling-_dbus_string_append_len-.txt (text/plain), 1.14 KB, created by Ralf Habacker on 2015-05-06 07:26:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ralf Habacker

Created: 2015-05-06 07:26:03 UTC

Size: 1.14 KB

patch

obsolete

>From 7d6fae51c9f38820766d98695c2209244adfc658 Mon Sep 17 00:00:00 2001
>From: Ralf Habacker <ralf.habacker@freenet.de>
>Date: Wed, 6 May 2015 09:18:20 +0200
>Subject: [PATCH 4/5] do_check_nonce: Fix of calling _dbus_string_append_len
> without checking return value (CID 54720).
>
>Reported by Coverity: CID: Unchecked return value (CHECKED_RETURN)
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=90021
>---
> dbus/dbus-nonce.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/dbus/dbus-nonce.c b/dbus/dbus-nonce.c
>index 44c46b2..c46f15a 100644
>--- a/dbus/dbus-nonce.c
>+++ b/dbus/dbus-nonce.c
>@@ -78,7 +78,13 @@ do_check_nonce (int fd, const DBusString *nonce, DBusError *error)
>         }
>       else
>         {
>-          _dbus_string_append_len(&buffer, _dbus_string_get_const_data (&p), n);
>+          if (!_dbus_string_append_len (&buffer, _dbus_string_get_const_data (&p), n))
>+            {
>+              dbus_set_error (error, DBUS_ERROR_NO_MEMORY, NULL);
>+              _dbus_string_free (&p);
>+              _dbus_string_free (&buffer);
>+              return FALSE;
>+            }
>           nleft -= n;
>         }
>     }
>-- 
>1.8.4.5
>

Actions: View | Splinter Review

Attachments on bug 90021: 115063 | 115064 | 115065 | 115068 | 115072 | 115073 | 115122 | 115234 | 115235 | 115236 | 115237 | 115246 | 115270 | 115576 | 115577 | 115578 | 115579 | 115580 | 115635 | 117015 | 119577 | 119578

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.