Attachment 115934 Details for Bug 86818 – exit with 0

[patch] exit with 0

0001-daemon-Exit-with-code-0-on-SIGINT-and-SIGTERM.patch (text/plain), 1.02 KB, created by Peter Meerwald on 2015-05-20 23:41:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Peter Meerwald

Created: 2015-05-20 23:41:59 UTC

Size: 1.02 KB

patch

obsolete

>From 5d02d8916b9c10279d908ad6f9c11ca89c5538b4 Mon Sep 17 00:00:00 2001
>From: Peter Meerwald <pmeerw@pmeerw.net>
>Date: Thu, 21 May 2015 01:31:01 +0200
>Subject: [PATCH] daemon: Exit with code 0 on SIGINT and SIGTERM
>
>see https://bugs.freedesktop.org/show_bug.cgi?id=86818
>
>an exit code of 1 makes systemd believe that the service failed;
>better return 0 to denote that PA sucessfully stopped on the user's
>request
>
>sidenote: systemd's SuccessExitStatus= could be used to turn code 1 into a
>code denoting success
>
>Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
>---
> src/daemon/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/daemon/main.c b/src/daemon/main.c
>index deb1e43..82dec01 100644
>--- a/src/daemon/main.c
>+++ b/src/daemon/main.c
>@@ -140,7 +140,7 @@ static void signal_callback(pa_mainloop_api*m, pa_signal_event *e, int sig, void
>         case SIGTERM:
>         default:
>             pa_log_info("Exiting.");
>-            m->quit(m, 1);
>+            m->quit(m, 0);
>             break;
>     }
> }
>-- 
>1.9.1
>

Actions: View | Splinter Review

Attachments on bug 86818: 115934

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.