Attachment 116258 Details for Bug 90748 – patch #3

[patch] patch #3

0003-mesa-allow-floating-point-render-targets-with-gles-3.patch (text/plain), 1.62 KB, created by Tapani Pälli on 2015-06-03 07:13:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tapani Pälli

Created: 2015-06-03 07:13:05 UTC

Size: 1.62 KB

patch

obsolete

>From 5c13d44fae79d67fa44da6e635657cc3f1acbc54 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Tapani=20P=C3=A4lli?= <tapani.palli@intel.com>
>Date: Wed, 3 Jun 2015 09:36:01 +0300
>Subject: [PATCH 3/3] mesa: allow floating point render targets with gles 3.0
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>commit e333035 introduced restriction for OES_texture_float extension,
>however floating point fbo attachments are OK for GLES >= 3.0.
>
>Patch fixes following warnings from DEQP tests:
>
>"QualityWarning (Framebuffer object could have checked as complete but did not.)"
>
>Signed-off-by: Tapani PÃ¤lli <tapani.palli@intel.com>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90748
>---
> src/mesa/main/fbobject.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
>index c5a7026..88afa0a 100644
>--- a/src/mesa/main/fbobject.c
>+++ b/src/mesa/main/fbobject.c
>@@ -830,8 +830,9 @@ test_attachment_completeness(const struct gl_context *ctx, GLenum format,
>           * these textures to be used as a render target, this is done via
>           * GL_EXT_color_buffer(_half)_float with set of new sized types.
>           */
>-         if (_mesa_is_gles(ctx) && (texImage->TexObject->_IsFloat ||
>-                                    texImage->TexObject->_IsHalfFloat)) {
>+         if ((_mesa_is_gles(ctx) && ctx->Version < 30) &&
>+             (texImage->TexObject->_IsFloat ||
>+              texImage->TexObject->_IsHalfFloat)) {
>             att_incomplete("bad internal format");
>             att->Complete = GL_FALSE;
>             return;
>-- 
>2.1.0
>

Actions: View | Splinter Review

Attachments on bug 90748: 116256 | 116257 | 116258 | 116259 | 116261

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.