Attachment 116306 Details for Bug 90749 – Option 2: slightly lower maximum line width

[patch] Option 2: slightly lower maximum line width

0001-i965-slightly-lower-maximum-line-width.patch (text/plain), 1.62 KB, created by Iago Toral on 2015-06-05 06:46:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Iago Toral

Created: 2015-06-05 06:46:58 UTC

Size: 1.62 KB

patch

obsolete

>From 2538021855b11403fcbc14b2e5eedf01715b1d05 Mon Sep 17 00:00:00 2001
>From: Iago Toral Quiroga <itoral@igalia.com>
>Date: Fri, 5 Jun 2015 08:17:31 +0200
>Subject: [PATCH] i965: slightly lower maximum line width
>
>There is dEQP wide-line test regressed after fe74fee8fa721a. The test
>seems to be bogus since it expects different renderings for widths
>like 7.250 and 7.375, while the spec indicates that both should be
>rounded to the nearest integer before rasterization, hence producing
>the same result.
>
>The test renders lines with various widths and one of the widths selected
>is the maximum width advertised. The test fails only for this width
>(currently 7.375) but not for 7.0, 7.125 or 7.250, so we simply lower
>the maximum width advertised to 0.725 to satisfy dEQP in this case.
>
>Fixes:
>dEQP-GLES3.functional.rasterization.fbo.rbo_multisample_max.primitives.lines_wide
>---
> src/mesa/drivers/dri/i965/brw_context.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c
>index 274a237..1726a3b 100644
>--- a/src/mesa/drivers/dri/i965/brw_context.c
>+++ b/src/mesa/drivers/dri/i965/brw_context.c
>@@ -433,8 +433,8 @@ brw_initialize_context_constants(struct brw_context *brw)
>       ctx->Const.MaxLineWidthAA = 40.0;
>       ctx->Const.LineWidthGranularity = 0.125;
>    } else if (brw->gen >= 6) {
>-      ctx->Const.MaxLineWidth = 7.375;
>-      ctx->Const.MaxLineWidthAA = 7.375;
>+      ctx->Const.MaxLineWidth = 7.25;
>+      ctx->Const.MaxLineWidthAA = 7.25;
>       ctx->Const.LineWidthGranularity = 0.125;
>    } else {
>       ctx->Const.MaxLineWidth = 7.0;
>-- 
>2.1.0
>

Actions: View | Splinter Review

Attachments on bug 90749: 116303 | 116306

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.