Attachment 116328 Details for Bug 90879 – 0001-Fix-a-crash-when-two-authentication-requests-are-in-.patch

[patch] 0001-Fix-a-crash-when-two-authentication-requests-are-in-.patch

0001-Fix-a-crash-when-two-authentication-requests-are-in-.patch (text/plain), 1.64 KB, created by Miloslav Trmac on 2015-06-05 23:21:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Miloslav Trmac

Created: 2015-06-05 23:21:50 UTC

Size: 1.64 KB

patch

obsolete

>From 4d99ffcc1c4067f0f6a52d2f072de58326077a25 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Miloslav=20Trma=C4=8D?= <mitr@redhat.com>
>Date: Sat, 6 Jun 2015 01:07:08 +0200
>Subject: [PATCH] Fix a crash when two authentication requests are in flight.
>
>To reproduce:
>1. pkttyagent -p $$ # or another suitable PID
># Keep it running, then in another terminal:
>2. pkcheck -p $that_pid -a org.freedesktop.policykit.exec -u
># Keep it running, then in another terminal:
>3. pkcheck -p $that_pid -a org.freedesktop.policykit.exec -u
>4. Then, in the pkttyagent prompt, press Enter.
>
>polkit_agent_text_listener_initiate_authentication was already setting
>an appropriate error code, so the g_assert was unnecessary.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=90879
>---
> src/polkitagent/polkitagenttextlistener.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/src/polkitagent/polkitagenttextlistener.c b/src/polkitagent/polkitagenttextlistener.c
>index b5c8a3f..e63c285 100644
>--- a/src/polkitagent/polkitagenttextlistener.c
>+++ b/src/polkitagent/polkitagenttextlistener.c
>@@ -546,12 +546,10 @@ polkit_agent_text_listener_initiate_authentication_finish (PolkitAgentListener
>                                                            GAsyncResult         *res,
>                                                            GError              **error)
> {
>-  PolkitAgentTextListener *listener = POLKIT_AGENT_TEXT_LISTENER (_listener);
>   gboolean ret;
> 
>   g_warn_if_fail (g_simple_async_result_get_source_tag (G_SIMPLE_ASYNC_RESULT (res)) ==
>                   polkit_agent_text_listener_initiate_authentication);
>-  g_assert (listener->active_session == NULL);
> 
>   ret = FALSE;
> 
>-- 
>2.4.2
>

Actions: View | Splinter Review

Attachments on bug 90879: 116328

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.