Attachment 116586 Details for Bug 89366 – cancel work to avoid oops

[patch] cancel work to avoid oops

0001-drm-dp-cancel-any-work-on-disconnect.patch (text/plain), 1.00 KB, created by Dave Airlie on 2015-06-19 00:17:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dave Airlie

Created: 2015-06-19 00:17:35 UTC

Size: 1.00 KB

patch

obsolete

>From 8b964d45f69cb0a803160d42f46b7c972af8db82 Mon Sep 17 00:00:00 2001
>From: Dave Airlie <airlied@redhat.com>
>Date: Fri, 19 Jun 2015 00:15:04 +1000
>Subject: [PATCH] drm/dp: cancel any work on disconnect
>
>Since we might have queued work but it hasn't executed yet
>this could cause an oops in drm_dp_check_and_send_link_address.
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89366
>
>Signed-off-by: Dave Airlie <airlied@redhat.com>
>---
> drivers/gpu/drm/drm_dp_mst_topology.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
>index fb65f5d..7678cb5 100644
>--- a/drivers/gpu/drm/drm_dp_mst_topology.c
>+++ b/drivers/gpu/drm/drm_dp_mst_topology.c
>@@ -1936,6 +1936,8 @@ int drm_dp_mst_topology_mgr_set_mst(struct drm_dp_mst_topology_mgr *mgr, bool ms
> 
> 		ret = 0;
> 	} else {
>+		/* flush any pending work */
>+		cancel_work_sync(&mgr->work);
> 		/* disable MST on the device */
> 		mstb = mgr->mst_primary;
> 		mgr->mst_primary = NULL;
>-- 
>2.4.1
>

Actions: View | Splinter Review

Attachments on bug 89366: 116586 | 116587 | 116591

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.