Attachment 116847 Details for Bug 80500 – [PATCH] i965: allocate at least 1 BLEND_STATE element

[patch] [PATCH] i965: allocate at least 1 BLEND_STATE element

0001-i965-allocate-at-least-1-BLEND_STATE-element.patch (text/plain), 1.31 KB, created by Mike Stroyan on 2015-07-01 16:40:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mike Stroyan

Created: 2015-07-01 16:40:26 UTC

Size: 1.31 KB

patch

obsolete

>From 2165cfa2b70dab5c333bcbc5c1eb3a3465ba94f9 Mon Sep 17 00:00:00 2001
>From: Mike Stroyan <mike@LunarG.com>
>Date: Wed, 1 Jul 2015 10:02:37 -0600
>Subject: [PATCH] i965: allocate at least 1 BLEND_STATE element
>
>When there are no color buffer render targets, gen6 and gen7 still
>use the first BLEND_STATE element to determine alpha test.
>gen6_upload_blend_state was allocating zero elements when
>ctx->Color.AlphaEnabled was false.
>That left _3DSTATE_CC_STATE_POINTERS or _3DSTATE_BLEND_STATE_POINTERS
>pointing to random data from some previous brw_state_batch().
>That sometimes suppressed depth rendering when those bits
>happened to mean COMPAREFUNC_NEVER.
>This produced flickering shadows for dota2 reborn.
>---
> src/mesa/drivers/dri/i965/gen6_cc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/mesa/drivers/dri/i965/gen6_cc.c b/src/mesa/drivers/dri/i965/gen6_cc.c
>index 2bfa271..2b76e24 100644
>--- a/src/mesa/drivers/dri/i965/gen6_cc.c
>+++ b/src/mesa/drivers/dri/i965/gen6_cc.c
>@@ -51,7 +51,7 @@ gen6_upload_blend_state(struct brw_context *brw)
>     * with render target 0, which will reference BLEND_STATE[0] for
>     * alpha test enable.
>     */
>-   if (nr_draw_buffers == 0 && ctx->Color.AlphaEnabled)
>+   if (nr_draw_buffers == 0)
>       nr_draw_buffers = 1;
> 
>    size = sizeof(*blend) * nr_draw_buffers;
>-- 
>2.1.0
>

Actions: View | Splinter Review

Attachments on bug 80500: 101697 | 116847

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.