Attachment 117411 Details for Bug 91401 – possible fix

[patch] possible fix

0001-drm-radeon-combios-add-some-validation-of-lvds-value.patch (text/plain), 1.61 KB, created by Alex Deucher on 2015-07-28 02:15:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2015-07-28 02:15:13 UTC

Size: 1.61 KB

patch

obsolete

>From b7725f78bdc35ddba1f382f9fa6ff889ea54024e Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexander.deucher@amd.com>
>Date: Mon, 27 Jul 2015 19:24:31 -0400
>Subject: [PATCH] drm/radeon/combios: add some validation of lvds values
>
>Fixes a broken hsync start value uncovered by:
>abc0b1447d4974963548777a5ba4a4457c82c426
>(drm: Perform basic sanity checks on probed modes)
>
>The driver handled the bad hsync start elsewhere, but
>the above commit prevented it from getting added.
>
>bug:
>https://bugs.freedesktop.org/show_bug.cgi?id=91401
>
>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>Cc: stable@vger.kernel.org
>---
> drivers/gpu/drm/radeon/radeon_combios.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/radeon/radeon_combios.c b/drivers/gpu/drm/radeon/radeon_combios.c
>index 3e5f6b7..c097d3a 100644
>--- a/drivers/gpu/drm/radeon/radeon_combios.c
>+++ b/drivers/gpu/drm/radeon/radeon_combios.c
>@@ -1255,10 +1255,15 @@ struct radeon_encoder_lvds *radeon_combios_get_lvds_info(struct radeon_encoder
> 
> 			if ((RBIOS16(tmp) == lvds->native_mode.hdisplay) &&
> 			    (RBIOS16(tmp + 2) == lvds->native_mode.vdisplay)) {
>+				u32 hss = (RBIOS16(tmp + 21) - RBIOS16(tmp + 19) - 1) * 8;
>+
>+				if (hss > lvds->native_mode.hdisplay)
>+					hss = (10 - 1) * 8;
>+
> 				lvds->native_mode.htotal = lvds->native_mode.hdisplay +
> 					(RBIOS16(tmp + 17) - RBIOS16(tmp + 19)) * 8;
> 				lvds->native_mode.hsync_start = lvds->native_mode.hdisplay +
>-					(RBIOS16(tmp + 21) - RBIOS16(tmp + 19) - 1) * 8;
>+					hss;
> 				lvds->native_mode.hsync_end = lvds->native_mode.hsync_start +
> 					(RBIOS8(tmp + 23) * 8);
> 
>-- 
>1.8.3.1
>

Actions: View | Splinter Review

Attachments on bug 91401: 117254 | 117255 | 117272 | 117398 | 117400 | 117404 | 117405 | 117410 | 117411

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.