Attachment 117432 Details for Bug 91497 – proposed patch

[patch] proposed patch

0001-Avoid-n-in-echo-n-foo-sys-bar.patch (text/plain), 1.36 KB, created by Alexandre Rostovtsev on 2015-07-29 02:28:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alexandre Rostovtsev

Created: 2015-07-29 02:28:53 UTC

Size: 1.36 KB

patch

obsolete

>From ffce4bc35a34b6b543e2ae2828a3096a19ebb1ae Mon Sep 17 00:00:00 2001
>From: Alexandre Rostovtsev <tetromino@gentoo.org>
>Date: Tue, 28 Jul 2015 22:24:56 -0400
>Subject: [PATCH] Avoid -n in "echo -n foo > /sys/bar"
>
>It's not portable and not needed.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=91497
>---
> pm/pm-functions.in | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/pm/pm-functions.in b/pm/pm-functions.in
>index c82be30..a68f955 100644
>--- a/pm/pm-functions.in
>+++ b/pm/pm-functions.in
>@@ -294,13 +294,13 @@ done
> if [ -z "$SUSPEND_MODULE" ]; then
> 	if grep -q mem /sys/power/state; then
> 		SUSPEND_MODULE="kernel"
>-		do_suspend() { echo -n "mem" >/sys/power/state; }
>+		do_suspend() { echo "mem" >/sys/power/state; }
> 	elif [ -c /dev/pmu ] && pm-pmu --check; then
> 		SUSPEND_MODULE="kernel"
> 		do_suspend() { pm-pmu --suspend; }
> 	elif grep -q standby /sys/power/state; then
> 		SUSPEND_MODULE="kernel"
>-		do_suspend() { echo -n "standby" >/sys/power/state; }
>+		do_suspend() { echo "standby" >/sys/power/state; }
> 	fi
> fi
> 
>@@ -312,8 +312,8 @@ if [ -z "$HIBERNATE_MODULE" ] && \
> 	{
> 		[ -n "${HIBERNATE_MODE}" ] && \
> 		grep -qw "${HIBERNATE_MODE}" /sys/power/disk && \
>-		echo -n "${HIBERNATE_MODE}" > /sys/power/disk
>-		echo -n "disk" > /sys/power/state
>+		echo "${HIBERNATE_MODE}" > /sys/power/disk
>+		echo "disk" > /sys/power/state
> 	}
> fi
> 
>-- 
>2.4.6
>

Actions: View | Splinter Review

Attachments on bug 91497: 117432 | 122011

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.