Attachment 11798 Details for Bug 12606 – server-1.4-branch backport

[patch] server-1.4-branch backport

exa-negative-tile-offsets.diff (text/plain), 1.02 KB, created by Michel Dänzer on 2007-09-28 00:40:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michel Dänzer

Created: 2007-09-28 00:40:16 UTC

Size: 1.02 KB

patch

obsolete

>commit e1ac9c0e7a6167f14cb7899e585eeae74bb5d55d
>Author: Michel DÃ¤nzer <michel@tungstengraphics.com>
>Date:   Thu Sep 27 13:08:41 2007 +0200
>
>    EXA: Make sure tile offsets passed to drivers are never negative.
>    
>    Thanks to BjÃ¶rn Steinbrink for pointing out the problem on IRC.
>
>diff --git a/exa/exa_accel.c b/exa/exa_accel.c
>index cc383cc..d19e3f4 100644
>--- a/exa/exa_accel.c
>+++ b/exa/exa_accel.c
>@@ -1187,7 +1187,8 @@ exaFillRegionTiled (DrawablePtr	pDrawable,
> 	    int dstY = pBox->y1;
> 	    int tileY;
> 
>-	    tileY = (dstY - pDrawable->y - pPatOrg->y) % tileHeight;
>+	    modulus(dstY - pDrawable->y - pPatOrg->y, tileHeight, tileY);
>+
> 	    while (height > 0) {
> 		int width = pBox->x2 - pBox->x1;
> 		int dstX = pBox->x1;
>@@ -1198,7 +1199,8 @@ exaFillRegionTiled (DrawablePtr	pDrawable,
> 		    h = height;
> 		height -= h;
> 
>-		tileX = (dstX - pDrawable->x - pPatOrg->x) % tileWidth;
>+		modulus(dstX - pDrawable->x - pPatOrg->x, tileWidth, tileX);
>+
> 		while (width > 0) {
> 		    int w = tileWidth - tileX;
> 		    if (w > width)

Actions: View | Splinter Review

Attachments on bug 12606: 11798

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.