Attachment 11799 Details for Bug 12542 – patch to ry

[patch] patch to ry

preferredmode-deadloop-fix.patch (text/plain), 1.04 KB, created by Hong Liu on 2007-09-28 01:05:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Hong Liu

Created: 2007-09-28 01:05:01 UTC

Size: 1.04 KB

patch

obsolete

>diff --git a/hw/xfree86/modes/xf86Crtc.c b/hw/xfree86/modes/xf86Crtc.c
>index 064ff16..78479bb 100644
>--- a/hw/xfree86/modes/xf86Crtc.c
>+++ b/hw/xfree86/modes/xf86Crtc.c
>@@ -1400,25 +1400,33 @@ xf86ProbeOutputModes (ScrnInfoPtr scrn, int maxX, int maxY)
> 
> 	if (preferred_mode)
> 	{
>-	    for (mode = output->probed_modes; mode; mode = mode->next)
>+	    mode = output->probed_modes;
>+	    while (mode)
> 	    {
>+		DisplayModePtr next;
>+
> 		if (!strcmp (preferred_mode, mode->name))
> 		{
>+		    next = mode->next;
> 		    if (mode != output->probed_modes)
> 		    {
> 			if (mode->prev)
>-			    mode->prev->next = mode->next;
>-			if (mode->next)
>-			    mode->next->prev = mode->prev;
>+			    mode->prev->next = next;
>+			if (next)
>+			    next->prev = mode->prev;
> 			mode->next = output->probed_modes;
> 			output->probed_modes->prev = mode;
> 			mode->prev = NULL;
> 			output->probed_modes = mode;
> 		    }
> 		    mode->type |= M_T_PREFERRED;
>+		    mode = next;
>+		    continue;
> 		}
> 		else
> 		    mode->type &= ~M_T_PREFERRED;
>+
>+		mode = mode->next;
> 	    }
> 	}
>

Actions: View | Splinter Review

Attachments on bug 12542: 11710 | 11711 | 11712 | 11713 | 11777 | 11799 | 11870 | 11871

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.