Attachment 118337 Details for Bug 92016 – fix the multitap click count

[patch] fix the multitap click count

0001-touchpad-fix-the-number-of-button-clicks-in-multitap.patch (text/plain), 1.35 KB, created by Peter Hutterer on 2015-09-17 23:17:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Peter Hutterer

Created: 2015-09-17 23:17:38 UTC

Size: 1.35 KB

patch

obsolete

>From 04edec0ff1bc68eb982ab8cba08a2d80cc59938f Mon Sep 17 00:00:00 2001
>From: Peter Hutterer <peter.hutterer@who-t.net>
>Date: Fri, 18 Sep 2015 09:14:43 +1000
>Subject: [PATCH libinput] touchpad: fix the number of button clicks in
> multitap
>
>tap-tap-down-move should emit 1 click + press, not 2 clicks + press
>
>https://bugs.freedesktop.org/show_bug.cgi?id=92016
>
>Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
>---
> src/evdev-mt-touchpad-tap.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
>diff --git a/src/evdev-mt-touchpad-tap.c b/src/evdev-mt-touchpad-tap.c
>index 753fc6b..dda528a 100644
>--- a/src/evdev-mt-touchpad-tap.c
>+++ b/src/evdev-mt-touchpad-tap.c
>@@ -596,21 +596,11 @@ tp_tap_multitap_down_handle_event(struct tp_dispatch *tp,
> 		break;
> 	case TAP_EVENT_TOUCH:
> 		tp->tap.state = TAP_STATE_DRAGGING_2;
>-		tp_tap_notify(tp,
>-			      tp->tap.multitap_last_time,
>-			      1,
>-			      LIBINPUT_BUTTON_STATE_RELEASED);
>-		tp_tap_notify(tp, time, 1, LIBINPUT_BUTTON_STATE_PRESSED);
> 		tp_tap_clear_timer(tp);
> 		break;
> 	case TAP_EVENT_MOTION:
> 	case TAP_EVENT_TIMEOUT:
> 		tp->tap.state = TAP_STATE_DRAGGING;
>-		tp_tap_notify(tp,
>-			      tp->tap.multitap_last_time,
>-			      1,
>-			      LIBINPUT_BUTTON_STATE_RELEASED);
>-		tp_tap_notify(tp, time, 1, LIBINPUT_BUTTON_STATE_PRESSED);
> 		tp_tap_clear_timer(tp);
> 		break;
> 	case TAP_EVENT_BUTTON:
>-- 
>2.4.3
>

Actions: View | Splinter Review

Attachments on bug 92016: 118337

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.