Attachment 120018 Details for Bug 93069 – Fix 'warning: pointer targets in assignment differ in signedness [-Wpointer-sign]'.

[patch] Fix 'warning: pointer targets in assignment differ in signedness [-Wpointer-sign]'.

0001-Fix-warning-pointer-targets-in-assignment-differ-in-.patch (text/plain), 1.11 KB, created by Ralf Habacker on 2015-11-22 16:02:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ralf Habacker

Created: 2015-11-22 16:02:10 UTC

Size: 1.11 KB

patch

obsolete

>From 725dfaef9228db48c3ecdf19e9dd8cb20014cefb Mon Sep 17 00:00:00 2001
>From: Ralf Habacker <ralf.habacker@freenet.de>
>Date: Sun, 22 Nov 2015 17:00:51 +0100
>Subject: [PATCH] Fix 'warning: pointer targets in assignment differ in
> signedness [-Wpointer-sign]'.
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=93069
>---
> dbus/dbus-marshal-header.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/dbus/dbus-marshal-header.c b/dbus/dbus-marshal-header.c
>index 48151c6..73a6152 100644
>--- a/dbus/dbus-marshal-header.c
>+++ b/dbus/dbus-marshal-header.c
>@@ -1458,7 +1458,7 @@ _dbus_header_toggle_flag (DBusHeader   *header,
>                           dbus_uint32_t flag,
>                           dbus_bool_t   value)
> {
>-  unsigned char *flags_p;
>+  char *flags_p;
> 
>   flags_p = _dbus_string_get_data_len (&header->data, FLAGS_OFFSET, 1);
> 
>@@ -1479,7 +1479,7 @@ dbus_bool_t
> _dbus_header_get_flag (DBusHeader   *header,
>                        dbus_uint32_t flag)
> {
>-  const unsigned char *flags_p;
>+  const char *flags_p;
> 
>   flags_p = _dbus_string_get_const_data_len (&header->data, FLAGS_OFFSET, 1);
> 
>-- 
>1.8.4.5
>

Actions: View | Splinter Review

Attachments on bug 93069: 120017 | 120018 | 120019 | 120020 | 120021 | 120022 | 120023 | 120024 | 120027 | 120028 | 120029 | 120030 | 120031 | 120032 | 120033 | 120034 | 120035 | 120055 | 120056 | 120069 | 120074 | 120075 | 120076 | 120081 | 120085 | 120143 | 120144 | 120145 | 121645 | 121646 | 121647 | 121648 | 121654 | 121660

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.