Attachment 120313 Details for Bug 92725 – allow bloated rx buffer

allow bloated rx buffer

mbim-huawei-rx-buffer-test.diff (text/plain), 993 bytes, created by Bjørn Mork on 2015-12-03 18:16:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bjørn Mork

Created: 2015-12-03 18:16:19 UTC

Size: 993 bytes

patch

obsolete

>diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
>index a187f08113ec..66954b495e8d 100644
>--- a/drivers/net/usb/cdc_ncm.c
>+++ b/drivers/net/usb/cdc_ncm.c
>@@ -150,7 +150,7 @@ static u32 cdc_ncm_check_rx_max(struct usbnet *dev, u32 new_rx)
> 
> 	/* clamp new_rx to sane values */
> 	min = USB_CDC_NCM_NTB_MIN_IN_SIZE;
>-	max = min_t(u32, CDC_NCM_NTB_MAX_SIZE_RX, le32_to_cpu(ctx->ncm_parm.dwNtbInMaxSize));
>+	max = min_t(u32, 131072, le32_to_cpu(ctx->ncm_parm.dwNtbInMaxSize));
> 
> 	/* dwNtbInMaxSize spec violation? Use MIN size for both limits */
> 	if (max < min) {
>@@ -612,7 +612,7 @@ static int cdc_ncm_setup(struct usbnet *dev)
> 	/* be conservative when selecting intial buffer size to
> 	 * increase the number of hosts this will work for
> 	 */
>-	def_rx = min_t(u32, CDC_NCM_NTB_DEF_SIZE_RX,
>+	def_rx = min_t(u32, 131072,
> 		       le32_to_cpu(ctx->ncm_parm.dwNtbInMaxSize));
> 	def_tx = min_t(u32, CDC_NCM_NTB_DEF_SIZE_TX,
> 		       le32_to_cpu(ctx->ncm_parm.dwNtbOutMaxSize));

Actions: View

Attachments on bug 92725: 119284 | 120295 | 120313 | 120339 | 120352 | 120357

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.