Attachment 120325 Details for Bug 93240 – ViaGammaDisable function improvement patch

ViaGammaDisable function improvement patch

0004-Made-improvements-to-ViaGammaDisable-function-inside.patch (text/plain), 3.03 KB, created by Kevin Brace on 2015-12-04 05:41:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kevin Brace

Created: 2015-12-04 05:41:37 UTC

Size: 3.03 KB

patch

obsolete

>From 32a3b072bd7afce50f67036dbfc0174de2c70396 Mon Sep 17 00:00:00 2001
>From: Kevin Brace <kevinbrace@gmx.com>
>Date: Sun, 29 Nov 2015 06:44:44 -0800
>Subject: [PATCH 04/10] Made improvements to ViaGammaDisable function inside
> via_display.c. The improved code will now make sure
> that UniChrome graphics (CLE266, KM400, etc.) will
> execute a certain code path, and UniChrome Pro and
> Chrome 9 graphics will execute another code path. It
> is unclear if the previous revision of the code had
> issues or not, but since the previous version of the
> code was not very strict on this matter, it was
> determined that this issue should be addressed.
> Furthermore, gamma correction feature for DVP
> (Digital Video Port) will now be turned off for
> UniChrome Pro and Chrome 9 graphics.
>
>---
> src/via_display.c |   36 +++++++++++++++++++++++++++---------
> 1 file changed, 27 insertions(+), 9 deletions(-)
>
>diff --git a/src/via_display.c b/src/via_display.c
>index 02353ee..33198ae 100644
>--- a/src/via_display.c
>+++ b/src/via_display.c
>@@ -209,8 +209,9 @@ VIALoadRgbLut(ScrnInfoPtr pScrn, int start, int numColors, LOCO *colors)
>     hwp->disablePalette(hwp);
> }
> 
>-void
>-ViaGammaDisable(ScrnInfoPtr pScrn)
>+/* Gamma correction will be disabled on both primary and secondary */
>+/* displays, and DVP (Digital Video Port). */
>+void ViaGammaDisable(ScrnInfoPtr pScrn)
> {
>     VIAPtr pVia = VIAPTR(pScrn);
>     vgaHWPtr hwp = VGAHWPTR(pScrn);
>@@ -218,27 +219,44 @@ ViaGammaDisable(ScrnInfoPtr pScrn)
>     switch (pVia->Chipset) {
>         case VIA_CLE266:
>         case VIA_KM400:
>+
>+/* It is not clear what 0x3c5.0x16[7] really does.*/
>             ViaSeqMask(hwp, 0x16, 0x00, 0x80);
>             break;
>         default:
>+
>+/* Digital Video Port (DVP) Gamma Correction: 0x3X5.0x32[1] */
>+            ViaCrtcMask(hwp, 0x32, 0x00, 0x02);
>+
>+/* Primary Display Gamma Correction: 0x3X5.0x33[7] */
>             ViaCrtcMask(hwp, 0x33, 0x00, 0x80);
>             break;
>     }
> 
>-    /* Disable gamma on secondary */
>-    /* This is needed or the hardware will lockup */
>-    ViaSeqMask(hwp, 0x1A, 0x00, 0x01);
>-    ViaCrtcMask(hwp, 0x6A, 0x00, 0x02);
>+/* Disable gamma correction on secondary display. */
>+/* This is needed or the hardware will lockup. */
>     switch (pVia->Chipset) {
>         case VIA_CLE266:
>         case VIA_KM400:
>-        case VIA_K8M800:
>-        case VIA_PM800:
>+            ViaCrtcMask(hwp, 0x6a, 0x00, 0x02);
>             break;
>         default:
>-            ViaCrtcMask(hwp, 0x6A, 0x00, 0x20);
>+
>+/* Second Display 8/6 Bits LUT: 0x3X5.0x6a[5] */
>+/* LCD Gamma Enable: 0x3X5.0x6a[1] */
>+/* In addition to disabling gamma correction on secondary display, */
>+/* also set its LUT to 6-bit LUT mode. */
>+/* Not sure why LUT for the secondary display needs to be set to */
>+/* 6-bit LUT mode. */
>+            ViaCrtcMask(hwp, 0x6a, 0x00, 0x22);
>             break;
>     }
>+
>+/* LUT Shadow Access: 0x3c5.0x1a[0] */
>+/* Map 0x3c6 / 0x3c7 / 0x3c8 / 0x3c9 address to Primary Displayâs LUT. */
>+/* Not sure why this has to be done. */
>+    ViaSeqMask(hwp, 0x1a, 0x00, 0x01);
>+
> }
> 
> void
>-- 
>1.7.9.5
>

Actions: View

Attachments on bug 93240: 120325

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.