Attachment 121065 Details for Bug 93599 – attachment-13944-0.html

attachment-13944-0.html

attachment-13944-0.html (text/html), 3.15 KB, created by Darius Spitznagel on 2016-01-15 13:58:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Darius Spitznagel

Created: 2016-01-15 13:58:02 UTC

Size: 3.15 KB

patch

obsolete

><html>
>  <head>
>    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
>  </head>
>  <body bgcolor="#FFFFFF" text="#000000">
>    <div class="moz-cite-prefix">On 01/15/2016 03:44 AM,
>      <a class="moz-txt-link-abbreviated" href="mailto:bugzilla-daemon@freedesktop.org">bugzilla-daemon@freedesktop.org</a> wrote:<br>
>    </div>
>    <blockquote
>      cite="mid:bug-93599-44904-7cP0bcgM8t@http.bugs.freedesktop.org%2F"
>      type="cite"> <base href="https://bugs.freedesktop.org/">
>      <p> </p>
>      <div> <b><a moz-do-not-send="true" class="bz_bug_link
>            bz_status_NEW " title="NEW - Strange green flashes with
>            &quot;Metro: Last Light Redux&quot; + &quot;Metro 2033
>            Redux&quot; with Intel Mesa driver"
>            href="https://bugs.freedesktop.org/show_bug.cgi?id=93599#c11">Comment
>            # 11</a> on <a moz-do-not-send="true" class="bz_bug_link
>            bz_status_NEW " title="NEW - Strange green flashes with
>            &quot;Metro: Last Light Redux&quot; + &quot;Metro 2033
>            Redux&quot; with Intel Mesa driver"
>            href="https://bugs.freedesktop.org/show_bug.cgi?id=93599">bug
>            93599</a> from <span class="vcard"><a
>              moz-do-not-send="true" class="email"
>              href="mailto:currojerez@riseup.net" title="Francisco Jerez
>              &lt;currojerez@riseup.net&gt;"> <span class="fn">Francisco
>                Jerez</span></a>
>          </span></b>
>        <pre>(In reply to Darius Spitznagel from <a moz-do-not-send="true" href="show_bug.cgi?id=93599#c10">comment #10</a>)
><span class="quote">&gt; (In reply to Francisco Jerez from <a moz-do-not-send="true" href="show_bug.cgi?id=93599#c9">comment #9</a>)
>&gt; &gt; Created <span class=""><a moz-do-not-send="true" href="attachment.cgi?id=121012" name="attach_121012" title="gen7_stall_before_ro_invalidation-2.patch">attachment 121012</a> <a moz-do-not-send="true" href="attachment.cgi?id=121012&amp;action=edit" title="gen7_stall_before_ro_invalidation-2.patch">[details]</a></span> <a moz-do-not-send="true" href="page.cgi?id=splinter.html&amp;bug=93599&amp;attachment=121012">[review]</a> [review] [review]
>&gt; &gt; gen7_stall_before_ro_invalidation-2.patch
>&gt; &gt; 
>&gt; &gt; Thanks for testing.  I'm attaching a (marginally) more optimal fix which
>&gt; &gt; avoids a redundant CS stall and HDC flush from the next pipe control, can
>&gt; &gt; you confirm whether it still gets rid of the corruption?
>&gt; &gt; 
>&gt; &gt; Thanks.
>&gt; 
>&gt; This optimized patch also works - there is no corruption!
>&gt; 
>&gt; Thanks again.</span>
>
>Cool, I just added your tested-by tag and sent the fix for review to the
>mesa-dev mailing list:
>
><a moz-do-not-send="true" href="http://lists.freedesktop.org/archives/mesa-dev/2016-January/104968.html">http://lists.freedesktop.org/archives/mesa-dev/2016-January/104968.html</a></pre>
>      </div>
>      <hr> <span>You are receiving this mail because:</span>
>      <ul>
>        <li>You reported the bug.</li>
>      </ul>
>    </blockquote>
>    Hello Francisco,<br>
>    I think you forgot the rename PIPE_CONTROL_DATA_CACHE_INVALIDATE
>    also in "src/mesa/drivers/dri/i965/brw_misc_state.c".<br>
>    <br>
>  </body>
></html>
>

<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">On 01/15/2016 03:44 AM,
      <a class="moz-txt-link-abbreviated" href="mailto:bugzilla-daemon@freedesktop.org">bugzilla-daemon@freedesktop.org</a> wrote:<br>
    </div>
    <blockquote
      cite="mid:bug-93599-44904-7cP0bcgM8t@http.bugs.freedesktop.org%2F"
      type="cite"> <base href="https://bugs.freedesktop.org/">
      <p> </p>
      <div> <b><a moz-do-not-send="true" class="bz_bug_link
            bz_status_NEW " title="NEW - Strange green flashes with
            &quot;Metro: Last Light Redux&quot; + &quot;Metro 2033
            Redux&quot; with Intel Mesa driver"
            href="https://bugs.freedesktop.org/show_bug.cgi?id=93599#c11">Comment
            # 11</a> on <a moz-do-not-send="true" class="bz_bug_link
            bz_status_NEW " title="NEW - Strange green flashes with
            &quot;Metro: Last Light Redux&quot; + &quot;Metro 2033
            Redux&quot; with Intel Mesa driver"
            href="https://bugs.freedesktop.org/show_bug.cgi?id=93599">bug
            93599</a> from <span class="vcard"><a
              moz-do-not-send="true" class="email"
              href="mailto:currojerez@riseup.net" title="Francisco Jerez
              &lt;currojerez@riseup.net&gt;"> <span class="fn">Francisco
                Jerez</span></a>
          </span></b>
        <pre>(In reply to Darius Spitznagel from <a moz-do-not-send="true" href="show_bug.cgi?id=93599#c10">comment #10</a>)
<span class="quote">&gt; (In reply to Francisco Jerez from <a moz-do-not-send="true" href="show_bug.cgi?id=93599#c9">comment #9</a>)
&gt; &gt; Created <span class=""><a moz-do-not-send="true" href="attachment.cgi?id=121012" name="attach_121012" title="gen7_stall_before_ro_invalidation-2.patch">attachment 121012</a> <a moz-do-not-send="true" href="attachment.cgi?id=121012&amp;action=edit" title="gen7_stall_before_ro_invalidation-2.patch">[details]</a></span> <a moz-do-not-send="true" href="page.cgi?id=splinter.html&amp;bug=93599&amp;attachment=121012">[review]</a> [review] [review]
&gt; &gt; gen7_stall_before_ro_invalidation-2.patch
&gt; &gt; 
&gt; &gt; Thanks for testing.  I'm attaching a (marginally) more optimal fix which
&gt; &gt; avoids a redundant CS stall and HDC flush from the next pipe control, can
&gt; &gt; you confirm whether it still gets rid of the corruption?
&gt; &gt; 
&gt; &gt; Thanks.
&gt; 
&gt; This optimized patch also works - there is no corruption!
&gt; 
&gt; Thanks again.</span>

Cool, I just added your tested-by tag and sent the fix for review to the
mesa-dev mailing list:

<a moz-do-not-send="true" href="http://lists.freedesktop.org/archives/mesa-dev/2016-January/104968.html">http://lists.freedesktop.org/archives/mesa-dev/2016-January/104968.html</a></pre>
      </div>
      <hr> <span>You are receiving this mail because:</span>
      <ul>
        <li>You reported the bug.</li>
      </ul>
    </blockquote>
    Hello Francisco,<br>
    I think you forgot the rename PIPE_CONTROL_DATA_CACHE_INVALIDATE
    also in "src/mesa/drivers/dri/i965/brw_misc_state.c".<br>
    <br>
  </body>
</html>

Actions: View

Attachments on bug 93599: 120998 | 121012 | 121065

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.