Attachment 121178 Details for Bug 93808 – [PATCH 1/3] ply-label: Don't crash if label plugin fails

[patch] [PATCH 1/3] ply-label: Don't crash if label plugin fails

0001-ply-label-Don-t-crash-if-label-plugin-fails.patch (text/plain), 1.30 KB, created by Fabian Vogt on 2016-01-21 12:14:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fabian Vogt

Created: 2016-01-21 12:14:59 UTC

Size: 1.30 KB

patch

obsolete

>From 99ee02fe20ae53323fe5756416e6a7d96a3baf8a Mon Sep 17 00:00:00 2001
>From: Fabian Vogt <fvogt@suse.com>
>Date: Thu, 21 Jan 2016 10:39:21 +0100
>Subject: [PATCH 1/3] ply-label: Don't crash if label plugin fails
>
>The label plugin's create_control function can return NULL if allocation
>failed, for example, but ply-label.c ignores that and uses the NULL control,
>causing various SEGVs.
>
>Signed-off-by: Fabian Vogt <fvogt@suse.com>
>---
> src/libply-splash-graphics/ply-label.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>diff --git a/src/libply-splash-graphics/ply-label.c b/src/libply-splash-graphics/ply-label.c
>index cfc8098..ba1f7b1 100644
>--- a/src/libply-splash-graphics/ply-label.c
>+++ b/src/libply-splash-graphics/ply-label.c
>@@ -125,6 +125,14 @@ ply_label_load_plugin (ply_label_t *label)
> 
>         label->control = label->plugin_interface->create_control ();
> 
>+        if (label->control == NULL) {
>+                ply_save_errno ();
>+                ply_close_module (label->module_handle);
>+                label->module_handle = NULL;
>+                ply_restore_errno ();
>+                return false;
>+        }
>+
>         if (label->text != NULL)
>                 label->plugin_interface->set_text_for_control (label->control,
>                                                                label->text);
>-- 
>2.7.0
>

Actions: View | Splinter Review

Attachments on bug 93808: 121178 | 121179 | 121180 | 121254 | 121596 | 129067 | 129068 | 129069 | 129070 | 129071

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.