Attachment 121401 Details for Bug 93284 – Revert "Quote pc_path virtual variable"

[patch] Revert "Quote pc_path virtual variable"

Revert-Quote-pcpath-virtual-variable.patch (text/plain), 1.20 KB, created by Dan Nicholson on 2016-01-29 22:12:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dan Nicholson

Created: 2016-01-29 22:12:11 UTC

Size: 1.20 KB

patch

obsolete

>From 8049e7ae7624c080b1a760fd554687a85b898b49 Mon Sep 17 00:00:00 2001
>From: Dan Nicholson <dbn.lists@gmail.com>
>Date: Fri, 29 Jan 2016 11:41:21 -0800
>Subject: [PATCH] Revert "Quote pc_path virtual variable"
>
>This reverts commit a6e8749ada5af1737b27f1eca1babe83e82af38c. With the
>--variable output only being unquoted when it appears needed, this can
>return to being a normally defined value.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=93284
>---
> pkg.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/pkg.c b/pkg.c
>index c546d46..b058e4e 100644
>--- a/pkg.c
>+++ b/pkg.c
>@@ -222,7 +222,6 @@ static Package *
> add_virtual_pkgconfig_package (void)
> {
>   Package *pkg = NULL;
>-  gchar *path_quoted;
> 
>   pkg = g_new0 (Package, 1);
> 
>@@ -235,8 +234,7 @@ add_virtual_pkgconfig_package (void)
> 
>   if (pkg->vars == NULL)
>     pkg->vars = g_hash_table_new (g_str_hash, g_str_equal);
>-  path_quoted = g_shell_quote (pkg_config_pc_path);
>-  g_hash_table_insert (pkg->vars, "pc_path", path_quoted);
>+  g_hash_table_insert (pkg->vars, "pc_path", pkg_config_pc_path);
> 
>   debug_spew ("Adding virtual 'pkg-config' package to list of known packages\n");
>   g_hash_table_insert (packages, pkg->key, pkg);
>-- 
>2.5.0

Actions: View | Splinter Review

Attachments on bug 93284: 121398 | 121399 | 121400 | 121401

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.