Attachment 121509 Details for Bug 93994 – Patch for fixing improper unducking when using this module with global=1 argument

[patch] Patch for fixing improper unducking when using this module with global=1 argument

0001-role-ducking-Fix-improper-unducking-behavior-in-case.patch (text/plain), 1.74 KB, created by Sangchul Lee on 2016-02-04 09:49:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Sangchul Lee

Created: 2016-02-04 09:49:06 UTC

Size: 1.74 KB

patch

obsolete

>From 736f641b69a10e25c3ea0771dd8691f775b81641 Mon Sep 17 00:00:00 2001
>From: Sangchul Lee <sc11.lee@samsung.com>
>Date: Thu, 4 Feb 2016 12:17:45 +0900
>Subject: [PATCH] role-ducking: Fix improper unducking behavior in case of
> operating globally
>
>Fix improper unducking behavior when using this module with "global=1" argument.
>
>Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
>---
> src/modules/module-role-ducking.c | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
>diff --git a/src/modules/module-role-ducking.c b/src/modules/module-role-ducking.c
>index 4f9be10..ee31b8c 100644
>--- a/src/modules/module-role-ducking.c
>+++ b/src/modules/module-role-ducking.c
>@@ -96,6 +96,22 @@ static bool sink_has_trigger_streams(struct userdata *u, pa_sink *s, pa_sink_inp
>     return false;
> }
> 
>+static bool sinks_have_trigger_streams(struct userdata *u, pa_sink *s, pa_sink_input *ignore) {
>+    bool ret = false;
>+
>+    pa_assert(u);
>+
>+    if (u->global) {
>+        uint32_t idx;
>+        PA_IDXSET_FOREACH(s, u->core->sinks, idx)
>+            if ((ret = sink_has_trigger_streams(u, s, ignore)))
>+                break;
>+    } else
>+        ret = sink_has_trigger_streams(u, s, ignore);
>+
>+    return ret;
>+}
>+
> static void apply_ducking_to_sink(struct userdata *u, pa_sink *s, pa_sink_input *ignore, bool duck) {
>     pa_sink_input *j;
>     uint32_t idx, role_idx;
>@@ -163,7 +179,7 @@ static pa_hook_result_t process(struct userdata *u, pa_sink_input *i, bool duck)
>     if (!i->sink)
>         return PA_HOOK_OK;
> 
>-    should_duck = sink_has_trigger_streams(u, i->sink, duck ? NULL : i);
>+    should_duck = sinks_have_trigger_streams(u, i->sink, duck ? NULL : i);
>     apply_ducking(u, i->sink, duck ? NULL : i, should_duck);
> 
>     return PA_HOOK_OK;
>-- 
>1.9.1
>

Actions: View | Splinter Review

Attachments on bug 93994: 121506 | 121509

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.