Attachment 121661 Details for Bug 93504 – 0001-touchpad-if-the-second-finger-is-within-20x5mm-bias-.patch

[patch] 0001-touchpad-if-the-second-finger-is-within-20x5mm-bias-.patch

0001-touchpad-if-the-second-finger-is-within-20x5mm-bias-.patch (text/plain), 1.97 KB, created by Peter Hutterer on 2016-02-11 01:46:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Peter Hutterer

Created: 2016-02-11 01:46:43 UTC

Size: 1.97 KB

patch

obsolete

>From 68633736b618f30e75bca885063ad3a94b97be55 Mon Sep 17 00:00:00 2001
>From: Peter Hutterer <peter.hutterer@who-t.net>
>Date: Thu, 11 Feb 2016 11:44:05 +1000
>Subject: [PATCH libinput] touchpad: if the second finger is within 20x5mm,
> bias towards 2fg scrolling
>
>Scrolling is much more common than a 2fg spread gesture, so if the finger
>position indicates that the fingers are next to each other, switch to
>scrolling immediately.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=93504
>
>Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
>---
> src/evdev-mt-touchpad-gestures.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
>diff --git a/src/evdev-mt-touchpad-gestures.c b/src/evdev-mt-touchpad-gestures.c
>index dc8d606..a9d7fa1 100644
>--- a/src/evdev-mt-touchpad-gestures.c
>+++ b/src/evdev-mt-touchpad-gestures.c
>@@ -325,8 +325,9 @@ tp_gesture_handle_state_unknown(struct tp_dispatch *tp, uint64_t time)
> 	struct tp_touch *first = tp->gesture.touches[0],
> 			*second = tp->gesture.touches[1];
> 	int dir1, dir2;
>-	int yres = tp->device->abs.absinfo_y->resolution;
>-	int vert_distance;
>+	int yres = tp->device->abs.absinfo_y->resolution,
>+	    xres = tp->device->abs.absinfo_x->resolution;
>+	int vert_distance, horiz_distance;
> 
> 	/* for two-finger gestures, if the fingers stay unmoving for a
> 	 * while, assume (slow) scroll */
>@@ -338,10 +339,16 @@ tp_gesture_handle_state_unknown(struct tp_dispatch *tp, uint64_t time)
> 
> 	/* Else check if one finger is > 20mm below the others */
> 	vert_distance = abs(first->point.y - second->point.y);
>+	horiz_distance = abs(first->point.x - second->point.x);
> 	if (vert_distance > 20 * yres &&
> 	    tp->gesture.enabled) {
> 		tp_gesture_init_pinch(tp);
> 		return GESTURE_STATE_PINCH;
>+	/* Else if the fingers are within 20x5mm of each other */
>+	} else if (vert_distance < 5 * yres &&
>+		   horiz_distance < 20 * xres) {
>+		tp_gesture_set_scroll_buildup(tp);
>+		return GESTURE_STATE_SCROLL;
> 	}
> 
> 	/* Else wait for both fingers to have moved */
>-- 
>2.5.0
>

Actions: View | Splinter Review

Attachments on bug 93504: 121614 | 121661

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.