Attachment 122663 Details for Bug 93491 – drm/i915/skl: Use WaForceContextSaveRestoreNonCoherent for all revs

[patch] drm/i915/skl: Use WaForceContextSaveRestoreNonCoherent for all revs

0001-drm-i915-skl-Use-WaForceContextSaveRestoreNonCoheren.patch (text/plain), 1.84 KB, created by Mika Kuoppala on 2016-04-01 15:16:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mika Kuoppala

Created: 2016-04-01 15:16:53 UTC

Size: 1.84 KB

patch

obsolete

>From dffb93d61174485f79b10baaeccffcbcf34a9b3d Mon Sep 17 00:00:00 2001
>From: Mika Kuoppala <mika.kuoppala@intel.com>
>Date: Fri, 1 Apr 2016 15:11:57 +0300
>Subject: [PATCH] drm/i915/skl: Use WaForceContextSaveRestoreNonCoherent for
> all revs
>
>Evidence suggest that this workaround is not only needed for F0
>but up to the most recent hw revisions. Extended the use of this
>workaround for all revisions.
>
>Previously the WaForceEnableNonCoherent has been tied to
>context noncoherence, atleast in hsds. Keep this tie.
>
>References: https://bugs.freedesktop.org/show_bug.cgi?id=93491
>Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
>---
> drivers/gpu/drm/i915/intel_ringbuffer.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
>index 2e864b7a528b..ad1a61768be1 100644
>--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
>+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
>@@ -980,7 +980,7 @@ static int gen9_init_workarounds(struct intel_engine_cs *engine)
> 
> 	/* WaForceContextSaveRestoreNonCoherent:skl,bxt */
> 	tmp = HDC_FORCE_CONTEXT_SAVE_RESTORE_NON_COHERENT;
>-	if (IS_SKL_REVID(dev, SKL_REVID_F0, SKL_REVID_F0) ||
>+	if (IS_SKL_REVID(dev, SKL_REVID_F0, REVID_FOREVER) ||
> 	    IS_BXT_REVID(dev, BXT_REVID_B0, REVID_FOREVER))
> 		tmp |= HDC_FORCE_CSR_NON_COHERENT_OVR_DISABLE;
> 	WA_SET_BIT_MASKED(HDC_CHICKEN0, tmp);
>@@ -1097,7 +1097,8 @@ static int skl_init_workarounds(struct intel_engine_cs *engine)
> 		WA_SET_BIT_MASKED(HIZ_CHICKEN,
> 				  BDW_HIZ_POWER_COMPILER_CLOCK_GATING_DISABLE);
> 
>-	if (IS_SKL_REVID(dev, 0, SKL_REVID_F0)) {
>+	/* This is tied to WaForceContextSaveRestoreNonCoherent */
>+	if (IS_SKL_REVID(dev, 0, REVID_FOREVER)) {
> 		/*
> 		 *Use Force Non-Coherent whenever executing a 3D context. This
> 		 * is a workaround for a possible hang in the unlikely event
>-- 
>2.5.0
>

Actions: View | Splinter Review

Attachments on bug 93491: 120672 | 120673 | 122606 | 122663 | 122828

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.