Attachment 122964 Details for Bug 91410 – [PATCH] drm/i915: Use cached cdclk value in i915_audio_component_get_cdclk_freq()

[patch] [PATCH] drm/i915: Use cached cdclk value in i915_audio_component_get_cdclk_freq()

0001-drm-i915-Use-cached-cdclk-value-in-i915_audio_compon.patch (text/plain), 1.47 KB, created by Ville Syrjala on 2016-04-15 09:09:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ville Syrjala

Created: 2016-04-15 09:09:47 UTC

Size: 1.47 KB

patch

obsolete

>From 3ddd0a3e1d4af8e338abb0af2db79e87ab25e13c Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= <ville.syrjala@linux.intel.com>
>Date: Fri, 15 Apr 2016 11:53:30 +0300
>Subject: [PATCH] drm/i915: Use cached cdclk value in
> i915_audio_component_get_cdclk_freq()
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>No point in reading the cdclk out from the hardware every single time
>since we have it cached already. Just return the cached value to the
>audio driver.
>
>Signed-off-by: Ville SyrjÃ¤lÃ¤ <ville.syrjala@linux.intel.com>
>---
> drivers/gpu/drm/i915/intel_audio.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
>index 56ba8765816e..1063108a9bab 100644
>--- a/drivers/gpu/drm/i915/intel_audio.c
>+++ b/drivers/gpu/drm/i915/intel_audio.c
>@@ -624,17 +624,11 @@ static void i915_audio_component_codec_wake_override(struct device *dev,
> static int i915_audio_component_get_cdclk_freq(struct device *dev)
> {
> 	struct drm_i915_private *dev_priv = dev_to_i915(dev);
>-	int ret;
> 
> 	if (WARN_ON_ONCE(!HAS_DDI(dev_priv)))
> 		return -ENODEV;
> 
>-	intel_display_power_get(dev_priv, POWER_DOMAIN_AUDIO);
>-	ret = dev_priv->display.get_display_clock_speed(dev_priv->dev);
>-
>-	intel_display_power_put(dev_priv, POWER_DOMAIN_AUDIO);
>-
>-	return ret;
>+	return dev_priv->cdclk_freq;
> }
> 
> static int i915_audio_component_sync_audio_rate(struct device *dev,
>-- 
>2.7.4
>

Actions: View | Splinter Review

Attachments on bug 91410: 117270 | 122889 | 122916 | 122963 | 122964 | 123122 | 123130

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.