Attachment 123292 Details for Bug 95061 – attachment-27609-0.html

attachment-27609-0.html

attachment-27609-0.html (text/html), 2.48 KB, created by Ole Liabø on 2016-04-27 07:44:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ole Liabø

Created: 2016-04-27 07:44:11 UTC

Size: 2.48 KB

patch

obsolete

><div dir="ltr">1. I would like to withdraw my original patch - it does not solve all the issues. Sorry for committing it prematurely. The original bug still remains though.<br>2. &quot;The main stream of a PDF always starts with offset 0&quot;: This is true if the filename PDFDoc constructor is used. But my bug refer to when the PDFDoc is created with a BaseStream as input. This stream could have a offset != 0, fex if you have concatenated many PDFS into one file. Today the code does not handle this case and the use of this PDFDoc constructor should be avoided until it&#39;s fixed. I&#39;m working on a more comprehensive patch.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 26, 2016 at 12:21 PM,  <span dir="ltr">&lt;<a href="mailto:bugzilla-daemon@freedesktop.org" target="_blank">bugzilla-daemon@freedesktop.org</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
>    
>      
>    
>    <div>
>      <p>
>        </p><div>
>            <b><a title="NEEDINFO - PDF hint table fails to load if PDFDoc is opened with stream start offset != 0" href="https://bugs.freedesktop.org/show_bug.cgi?id=95061#c3" target="_blank">Comment # 3</a>
>              on <a title="NEEDINFO - PDF hint table fails to load if PDFDoc is opened with stream start offset != 0" href="https://bugs.freedesktop.org/show_bug.cgi?id=95061" target="_blank">bug 95061</a>
>              from <span><a href="mailto:Thomas.Freitag@alfa.de" title="Thomas Freitag &lt;Thomas.Freitag@alfa.de&gt;" target="_blank"> <span>Thomas Freitag</span></a>
></span></b>
>        <pre>I&#39;m a little bit confused about it: 
>1. If I parse the PDF of <a href="https://bugs.freedesktop.org/show_bug.cgi?id=95061#c2" target="_blank">comment 2</a> i.e. with /utils/pdftoppm -png -f 1 -l 1
>-cropbox I don&#39;t get any error messages.
>2. The main stream of a PDF always starts with offset 0
>3. The PDF spec says about the H entry in the &quot;Linearization Parameter
>Dictionary&quot;: offset1 shall be the offset of the primary hint stream from the
>beginning(!!!) of the file.
>4. All offsets in poppler, i.e. also the xref offets, are offsets from the
>beginning of a file and never add some hypothetical offet of substreams</pre>
>        </div>
>      <p></p><span class="">
>      <hr>
>      <span>You are receiving this mail because:</span>
>      
>      <ul>
>          <li>You reported the bug.</li>
>      </ul>
>    </span></div>
></blockquote></div><br></div>

<div dir="ltr">1. I would like to withdraw my original patch - it does not solve all the issues. Sorry for committing it prematurely. The original bug still remains though.<br>2. &quot;The main stream of a PDF always starts with offset 0&quot;: This is true if the filename PDFDoc constructor is used. But my bug refer to when the PDFDoc is created with a BaseStream as input. This stream could have a offset != 0, fex if you have concatenated many PDFS into one file. Today the code does not handle this case and the use of this PDFDoc constructor should be avoided until it&#39;s fixed. I&#39;m working on a more comprehensive patch.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 26, 2016 at 12:21 PM,  <span dir="ltr">&lt;<a href="mailto:bugzilla-daemon@freedesktop.org" target="_blank">bugzilla-daemon@freedesktop.org</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
    
      
    
    <div>
      <p>
        </p><div>
            <b><a title="NEEDINFO - PDF hint table fails to load if PDFDoc is opened with stream start offset != 0" href="https://bugs.freedesktop.org/show_bug.cgi?id=95061#c3" target="_blank">Comment # 3</a>
              on <a title="NEEDINFO - PDF hint table fails to load if PDFDoc is opened with stream start offset != 0" href="https://bugs.freedesktop.org/show_bug.cgi?id=95061" target="_blank">bug 95061</a>
              from <span><a href="mailto:Thomas.Freitag@alfa.de" title="Thomas Freitag &lt;Thomas.Freitag@alfa.de&gt;" target="_blank"> <span>Thomas Freitag</span></a>
</span></b>
        <pre>I&#39;m a little bit confused about it: 
1. If I parse the PDF of <a href="https://bugs.freedesktop.org/show_bug.cgi?id=95061#c2" target="_blank">comment 2</a> i.e. with /utils/pdftoppm -png -f 1 -l 1
-cropbox I don&#39;t get any error messages.
2. The main stream of a PDF always starts with offset 0
3. The PDF spec says about the H entry in the &quot;Linearization Parameter
Dictionary&quot;: offset1 shall be the offset of the primary hint stream from the
beginning(!!!) of the file.
4. All offsets in poppler, i.e. also the xref offets, are offsets from the
beginning of a file and never add some hypothetical offet of substreams</pre>
        </div>
      <p></p><span class="">
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You reported the bug.</li>
      </ul>
    </span></div>
</blockquote></div><br></div>

Actions: View

Attachments on bug 95061: 123139 | 123292 | 123296 | 123297

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.