Attachment 123629 Details for Bug 95206 – possible fix

[patch] possible fix

0001-drm-radeon-fix-DP-mode-validation.patch (text/plain), 1.44 KB, created by Alex Deucher on 2016-05-11 20:22:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2016-05-11 20:22:56 UTC

Size: 1.44 KB

patch

obsolete

>From 30fb4025d5a4eaf056e18d56549ebfd03c7f450d Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexander.deucher@amd.com>
>Date: Wed, 11 May 2016 16:16:53 -0400
>Subject: [PATCH] drm/radeon: fix DP mode validation
>
>Switch the order of the loops to walk the rates on the top
>so we exhaust all DP 1.1 rate/lane combinations before trying
>DP 1.2 rate/lane combos.
>
>This avoids selecting rates that are supported by the monitor,
>but not the connector leading to valid modes getting rejected.
>
>bug:
>https://bugs.freedesktop.org/show_bug.cgi?id=95206
>
>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>Cc: stable@vger.kernel.org
>---
> drivers/gpu/drm/radeon/atombios_dp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/atombios_dp.c b/drivers/gpu/drm/radeon/atombios_dp.c
>index afa9db1..cead089a 100644
>--- a/drivers/gpu/drm/radeon/atombios_dp.c
>+++ b/drivers/gpu/drm/radeon/atombios_dp.c
>@@ -326,8 +326,8 @@ int radeon_dp_get_dp_link_config(struct drm_connector *connector,
> 			}
> 		}
> 	} else {
>-		for (lane_num = 1; lane_num <= max_lane_num; lane_num <<= 1) {
>-			for (i = 0; i < ARRAY_SIZE(link_rates) && link_rates[i] <= max_link_rate; i++) {
>+		for (i = 0; i < ARRAY_SIZE(link_rates) && link_rates[i] <= max_link_rate; i++) {
>+			for (lane_num = 1; lane_num <= max_lane_num; lane_num <<= 1) {
> 				max_pix_clock = (lane_num * link_rates[i] * 8) / bpp;
> 				if (max_pix_clock >= pix_clock) {
> 					*dp_lanes = lane_num;
>-- 
>2.5.5
>

Actions: View | Splinter Review

Attachments on bug 95206: 123350 | 123351 | 123352 | 123611 | 123618 | 123629

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.