Attachment 124085 Details for Bug 96215 – UpKbdBacklight: don't check the *end value when using g_ascii_strtoll

[patch] UpKbdBacklight: don't check the *end value when using g_ascii_strtoll

UpKbdBacklight-dont-check-the-end-value-when-using.patch (text/plain), 1008 bytes, created by Marco Trevisan (Treviño) on 2016-05-25 15:47:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marco Trevisan (Treviño)

Created: 2016-05-25 15:47:13 UTC

Size: 1008 bytes

patch

obsolete

>From e0578e60525adc12d4c60ee137d22fb657ddfe0a Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marco=20Trevisan=20=28Trevi=C3=B1o=29?= <mail@3v1n0.net>
>Date: Wed, 25 May 2016 17:46:37 +0200
>Subject: [PATCH] UpKbdBacklight: don't check the *end value when using
> g_ascii_strtoll
>
>g_ascii_strtoll would set end to match buf when a parsing error occurred,
>so there's no reason to also check what this is pointing to
>
>https://bugs.freedesktop.org/show_bug.cgi?id=96215
>---
> src/up-kbd-backlight.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/up-kbd-backlight.c b/src/up-kbd-backlight.c
>index b8e45af..11eeb66 100644
>--- a/src/up-kbd-backlight.c
>+++ b/src/up-kbd-backlight.c
>@@ -70,7 +70,7 @@ up_kbd_backlight_brightness_read (UpKbdBacklight *kbd_backlight)
> 
> 		if (brightness < 0 ||
> 		    brightness > kbd_backlight->priv->max_brightness ||
>-		    end == buf || *end != '\0') {
>+		    end == buf) {
> 			brightness = -1;
> 			g_warning ("failed to convert brightness: %s", buf);
> 		}
>-- 
>1.9.1

Actions: View | Splinter Review

Attachments on bug 96215: 124085

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.