Attachment 124409 Details for Bug 92766 – proposed patch

[patch] proposed patch

0001-Allow-ConstantDeceleration-and-AdaptiveDeceleration-.patch (text/plain), 1.87 KB, created by ebiggers3 on 2016-06-09 03:31:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ebiggers3

Created: 2016-06-09 03:31:09 UTC

Size: 1.87 KB

patch

obsolete

>From 18b8c67d9d595fda6ae2a723adbe646bdb78414d Mon Sep 17 00:00:00 2001
>From: Eric Biggers <ebiggers3@gmail.com>
>Date: Wed, 8 Jun 2016 22:03:11 -0500
>Subject: [PATCH] Allow ConstantDeceleration and AdaptiveDeceleration < 1.0
>
>As documented in xorg.conf(5), a value of ConstantDeceleration between 0
>and 1 will speed up the pointer.  However, values less than 1 actually
>had no effect.  Fix this.
>
>For consistency I also made the same change for AdaptiveDeceleration,
>which had the same behavior.
>
>Note that this bug only affected "ConstantDeceleration" as configured
>through xorg.conf, not "Device Accel Constant Deceleration" as configured
>through xinput.
>
>Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=92766
>Signed-off-by: Eric Biggers <ebiggers3@gmail.com>
>---
> hw/xfree86/common/xf86Xinput.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/hw/xfree86/common/xf86Xinput.c b/hw/xfree86/common/xf86Xinput.c
>index d18f53e..6e859c6 100644
>--- a/hw/xfree86/common/xf86Xinput.c
>+++ b/hw/xfree86/common/xf86Xinput.c
>@@ -130,7 +130,7 @@ ProcessVelocityConfiguration(DeviceIntPtr pDev, const char *devname, void *list,
> 
>     /* common settings (available via device properties) */
>     tempf = xf86SetRealOption(list, "ConstantDeceleration", 1.0);
>-    if (tempf > 1.0) {
>+    if (tempf != 1.0) {
>         xf86Msg(X_CONFIG, "%s: (accel) constant deceleration by %.1f\n",
>                 devname, tempf);
>         prop = XIGetKnownProperty(ACCEL_PROP_CONSTANT_DECELERATION);
>@@ -139,7 +139,7 @@ ProcessVelocityConfiguration(DeviceIntPtr pDev, const char *devname, void *list,
>     }
> 
>     tempf = xf86SetRealOption(list, "AdaptiveDeceleration", 1.0);
>-    if (tempf > 1.0) {
>+    if (tempf != 1.0) {
>         xf86Msg(X_CONFIG, "%s: (accel) adaptive deceleration by %.1f\n",
>                 devname, tempf);
>         prop = XIGetKnownProperty(ACCEL_PROP_ADAPTIVE_DECELERATION);
>-- 
>2.8.3
>

Actions: View | Splinter Review

Attachments on bug 92766: 124409

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.