Attachment 124609 Details for Bug 96399 – Fix unused-variable and unused-but-set-variable warnings in via_display.c

[patch] Fix unused-variable and unused-but-set-variable warnings in via_display.c

0001-Fix-unused-variable-and-unused-but-set-variable-warn.patch (text/plain), 3.17 KB, created by Xavier Bachelot on 2016-06-19 21:02:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Xavier Bachelot

Created: 2016-06-19 21:02:21 UTC

Size: 3.17 KB

patch

obsolete

>From eb9622ca81f509d2e07231de70014bb7603b04df Mon Sep 17 00:00:00 2001
>From: Xavier Bachelot <xavier@bachelot.org>
>Date: Sun, 19 Jun 2016 22:52:11 +0200
>Subject: [PATCH] Fix unused-variable and unused-but-set-variable warnings in
> via_display.c
>
>Signed-off-by: Xavier Bachelot <xavier@bachelot.org>
>---
> src/via_display.c | 16 ----------------
> 1 file changed, 16 deletions(-)
>
>diff --git a/src/via_display.c b/src/via_display.c
>index 696bb31..1467154 100644
>--- a/src/via_display.c
>+++ b/src/via_display.c
>@@ -2694,7 +2694,6 @@ iga1_crtc_dpms(xf86CrtcPtr crtc, int mode)
> {
>     ScrnInfoPtr pScrn = crtc->scrn;
>     VIAPtr pVia = VIAPTR(pScrn);
>-    VIABIOSInfoPtr pBIOSInfo = pVia->pBIOSInfo;
> 
>     DEBUG(xf86DrvMsg(pScrn->scrnIndex, X_INFO,
>                         "Entered iga1_crtc_dpms.\n"));
>@@ -2761,7 +2760,6 @@ iga1_crtc_restore(xf86CrtcPtr crtc)
>     ScrnInfoPtr pScrn = crtc->scrn;
>     vgaHWPtr hwp = VGAHWPTR(pScrn);
>     VIAPtr pVia = VIAPTR(pScrn);
>-    CARD8 tmp;
> 
>     DEBUG(xf86DrvMsg(pScrn->scrnIndex, X_INFO,
>                         "Entered iga1_crtc_restore.\n"));
>@@ -2845,7 +2843,6 @@ static void
> iga1_crtc_set_origin(xf86CrtcPtr crtc, int x, int y)
> {
>     ScrnInfoPtr pScrn = crtc->scrn;
>-    VIAPtr pVia = VIAPTR(pScrn);
> 
>     DEBUG(xf86DrvMsg(pScrn->scrnIndex, X_INFO,
>                         "Entered iga1_crtc_set_origin.\n"));
>@@ -2925,7 +2922,6 @@ iga1_crtc_gamma_set(xf86CrtcPtr crtc, CARD16 *red, CARD16 *green, CARD16 *blue,
>     ScrnInfoPtr pScrn = crtc->scrn;
>     vgaHWPtr hwp = VGAHWPTR(pScrn);
>     VIAPtr pVia = VIAPTR(pScrn);
>-    int SR1A, SR1B, CR67, CR6A;
>     LOCO colors[size];
>     int i;
> 
>@@ -2951,11 +2947,6 @@ iga1_crtc_gamma_set(xf86CrtcPtr crtc, CARD16 *red, CARD16 *green, CARD16 *blue,
> 
>     } else {
> 
>-        SR1A = hwp->readSeq(hwp, 0x1A);
>-        SR1B = hwp->readSeq(hwp, 0x1B);
>-        CR67 = hwp->readCrtc(hwp, 0x67);
>-        CR6A = hwp->readCrtc(hwp, 0x6A);
>-
>         for (i = 0; i < size; i++) {
>             hwp->writeDacWriteAddr(hwp, i);
>             hwp->writeDacData(hwp, colors[i].red);
>@@ -3175,7 +3166,6 @@ iga2_crtc_dpms(xf86CrtcPtr crtc, int mode)
> {
>     ScrnInfoPtr pScrn = crtc->scrn;
>     VIAPtr pVia = VIAPTR(pScrn);
>-    VIABIOSInfoPtr pBIOSInfo = pVia->pBIOSInfo;
> 
>     DEBUG(xf86DrvMsg(pScrn->scrnIndex, X_INFO,
>                         "Entered iga2_crtc_dpms.\n"));
>@@ -3206,8 +3196,6 @@ static void
> iga2_crtc_save(xf86CrtcPtr crtc)
> {
>     ScrnInfoPtr pScrn = crtc->scrn;
>-    vgaHWPtr hwp = VGAHWPTR(pScrn);
>-    VIAPtr pVia = VIAPTR(pScrn);
> 
>     DEBUG(xf86DrvMsg(pScrn->scrnIndex, X_INFO,
>                         "Entered iga2_crtc_save.\n"));
>@@ -3222,9 +3210,6 @@ static void
> iga2_crtc_restore(xf86CrtcPtr crtc)
> {
>     ScrnInfoPtr pScrn = crtc->scrn;
>-    vgaHWPtr hwp = VGAHWPTR(pScrn);
>-    VIAPtr pVia = VIAPTR(pScrn);
>-    CARD8 tmp;
> 
>     DEBUG(xf86DrvMsg(pScrn->scrnIndex, X_INFO,
>                         "Entered iga2_crtc_restore.\n"));
>@@ -3291,7 +3276,6 @@ static void
> iga2_crtc_set_origin(xf86CrtcPtr crtc, int x, int y)
> {
>     ScrnInfoPtr pScrn = crtc->scrn;
>-    VIAPtr pVia = VIAPTR(pScrn);
> 
>     DEBUG(xf86DrvMsg(pScrn->scrnIndex, X_INFO,
>                         "Entered iga2_crtc_set_origin.\n"));
>-- 
>2.5.5
>

Actions: View | Splinter Review

Attachments on bug 96399: 124357 | 124511 | 124595 | 124608 | 124609 | 124611 | 124612

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.