Attachment 124808 Details for Bug 96754 – Don't include execinfo.h for windows

[patch] Don't include execinfo.h for windows

Dont-include-execinfoh-for-windows.patch (text/plain), 1.34 KB, created by Nicolas Dufresne on 2016-06-30 18:45:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nicolas Dufresne

Created: 2016-06-30 18:45:43 UTC

Size: 1.34 KB

patch

obsolete

>From 6355e0ef6a871897a34c1fe1f10f62d147d8f43f Mon Sep 17 00:00:00 2001
>From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
>Date: Thu, 30 Jun 2016 14:11:48 -0400
>Subject: [PATCH] Don't include execinfo.h for windows
>
>And that even if we have GLIBC. This fixes a build issue in mingw.
>
>Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
>
>https://bugs.freedesktop.org/show_bug.cgi?id=96754
>---
> webrtc/base/checks.cc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/webrtc/base/checks.cc b/webrtc/base/checks.cc
>index 49a31f2..32a2f74 100644
>--- a/webrtc/base/checks.cc
>+++ b/webrtc/base/checks.cc
>@@ -16,7 +16,7 @@
> #include <cstdio>
> #include <cstdlib>
> 
>-#if defined(__GLIBCXX__) && !defined(__UCLIBC__)
>+#if defined(__GLIBCXX__) && !defined(__UCLIBC__) && !defined(WEBRTC_WIN)
> #include <cxxabi.h>
> #include <execinfo.h>
> #endif
>@@ -55,7 +55,7 @@ void PrintError(const char* format, ...) {
> // to get usable symbols on Linux. This is copied from V8. Chromium has a more
> // advanced stace trace system; also more difficult to copy.
> void DumpBacktrace() {
>-#if defined(__GLIBCXX__) && !defined(__UCLIBC__)
>+#if defined(__GLIBCXX__) && !defined(__UCLIBC__) && !defined(WEBRTC_WIN)
>   void* trace[100];
>   int size = backtrace(trace, sizeof(trace) / sizeof(*trace));
>   char** symbols = backtrace_symbols(trace, size);
>-- 
>2.7.4

Actions: View | Splinter Review

Attachments on bug 96754: 124808 | 124809 | 124810 | 124811 | 124812 | 124813 | 124814 | 124815 | 124817 | 124818 | 124914 | 124915 | 124916 | 124917 | 124918 | 124919 | 124920 | 124921 | 124922 | 124923

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.