Attachment 1250 Details for Bug 1803 – drm_lock.diff

[patch] drm_lock.diff

drm_lock.diff (text/plain), 7.77 KB, created by Stefan Dirsch on 2004-11-09 06:02:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stefan Dirsch

Created: 2004-11-09 06:02:23 UTC

Size: 7.77 KB

patch

obsolete

>diff -u -r ../drm.orig/i810_dma.c ./i810_dma.c
>--- ../drm.orig/i810_dma.c	2004-11-09 11:23:50.001477250 +0100
>+++ ./i810_dma.c	2004-11-09 11:28:35.346117947 +0100
>@@ -1040,10 +1040,7 @@
>    	drm_file_t	  *priv	  = filp->private_data;
>    	drm_device_t	  *dev	  = priv->dev;
> 
>-	if (!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
>-		DRM_ERROR("i810_flush_ioctl called without lock held\n");
>-		return -EINVAL;
>-	}
>+	LOCK_TEST_WITH_RETURN( dev, filp );
> 
>    	i810_flush_queue(dev);
>    	return 0;
>@@ -1065,10 +1062,7 @@
> 	if (copy_from_user(&vertex, (drm_i810_vertex_t *)arg, sizeof(vertex)))
> 		return -EFAULT;
> 
>-	if (!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
>-		DRM_ERROR("i810_dma_vertex called without lock held\n");
>-		return -EINVAL;
>-	}
>+	LOCK_TEST_WITH_RETURN( dev, filp );
> 
> 	DRM_DEBUG("i810 dma vertex, idx %d used %d discard %d\n",
> 		  vertex.idx, vertex.used, vertex.discard);
>@@ -1100,10 +1094,7 @@
>    	if (copy_from_user(&clear, (drm_i810_clear_t *)arg, sizeof(clear)))
> 		return -EFAULT;
> 
>-	if (!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
>-		DRM_ERROR("i810_clear_bufs called without lock held\n");
>-		return -EINVAL;
>-	}
>+	LOCK_TEST_WITH_RETURN( dev, filp );
> 
>  	/* GH: Someone's doing nasty things... */
>  	if (!dev->dev_private) {
>@@ -1124,10 +1115,8 @@
> 
> 	DRM_DEBUG("i810_swap_bufs\n");
> 
>-	if (!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
>-		DRM_ERROR("i810_swap_buf called without lock held\n");
>-		return -EINVAL;
>-	}
>+
>+	LOCK_TEST_WITH_RETURN( dev, filp ); 
> 
> 	i810_dma_dispatch_swap( dev );
>    	return 0;
>@@ -1162,10 +1151,7 @@
>    	if (copy_from_user(&d, (drm_i810_dma_t *)arg, sizeof(d)))
> 		return -EFAULT;
> 
>-	if (!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
>-		DRM_ERROR("i810_dma called without lock held\n");
>-		return -EINVAL;
>-	}
>+	LOCK_TEST_WITH_RETURN( dev, filp ); 
> 
> 	d.granted = 0;
> 
>@@ -1275,10 +1261,7 @@
> 	if (copy_from_user(&mc, (drm_i810_mc_t *)arg, sizeof(mc)))
> 		return -EFAULT;
> 
>-	if (!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
>-		DRM_ERROR("i810_dma_mc called without lock held\n");
>-		return -EINVAL;
>-	}
>+	LOCK_TEST_WITH_RETURN( dev, filp ); 
> 
> 	if (mc.idx >= dma->buf_count || mc.idx < 0)
> 		return -EINVAL;
>@@ -1326,10 +1309,7 @@
> 	drm_device_t *dev = priv->dev;
> 	drm_i810_private_t *dev_priv = (drm_i810_private_t *)dev->dev_private;
> 
>-	if (!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
>-		DRM_ERROR("i810_fstatus called without lock held\n");
>-		return -EINVAL;
>-	}
>+	LOCK_TEST_WITH_RETURN( dev, filp ); 
> 	return I810_READ(0x30008);
> }
> 
>@@ -1340,10 +1320,7 @@
> 	drm_device_t *dev = priv->dev;
> 	drm_i810_private_t *dev_priv = (drm_i810_private_t *)dev->dev_private;
> 
>-	if (!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
>-		DRM_ERROR("i810_ov0_flip called without lock held\n");
>-		return -EINVAL;
>-	}
>+	LOCK_TEST_WITH_RETURN( dev, filp ); 
> 
> 	//Tell the overlay to update
> 	I810_WRITE(0x30000,dev_priv->overlay_physical | 0x80000000);
>@@ -1385,10 +1362,7 @@
> 
> 	DRM_DEBUG("%s\n", __FUNCTION__);
> 
>-	if (!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
>-		DRM_ERROR("i810_flip_buf called without lock held\n");
>-		return -EINVAL;
>-	}
>+	LOCK_TEST_WITH_RETURN( dev, filp );
> 
> 	if (!dev_priv->page_flipping) 
> 		i810_do_init_pageflip( dev );
>diff -u -r ../drm.orig/i830_dma.c ./i830_dma.c
>--- ../drm.orig/i830_dma.c	2004-11-09 11:23:50.008476063 +0100
>+++ ./i830_dma.c	2004-11-09 11:30:55.356393023 +0100
>@@ -1327,10 +1327,7 @@
>    	drm_file_t	  *priv	  = filp->private_data;
>    	drm_device_t	  *dev	  = priv->dev;
> 
>-   	if(!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
>-		DRM_ERROR("i830_flush_ioctl called without lock held\n");
>-		return -EINVAL;
>-	}
>+	LOCK_TEST_WITH_RETURN( dev, filp ); 
> 
>    	i830_flush_queue(dev);
>    	return 0;
>@@ -1351,10 +1348,7 @@
> 	if (copy_from_user(&vertex, (drm_i830_vertex_t __user *)arg, sizeof(vertex)))
> 		return -EFAULT;
> 
>-   	if(!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
>-		DRM_ERROR("i830_dma_vertex called without lock held\n");
>-		return -EINVAL;
>-	}
>+	LOCK_TEST_WITH_RETURN( dev, filp ); 
> 
> 	DRM_DEBUG("i830 dma vertex, idx %d used %d discard %d\n",
> 		  vertex.idx, vertex.used, vertex.discard);
>@@ -1381,10 +1375,7 @@
>    	if (copy_from_user(&clear, (drm_i830_clear_t __user *)arg, sizeof(clear)))
> 		return -EFAULT;
>    
>-   	if(!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
>-		DRM_ERROR("i830_clear_bufs called without lock held\n");
>-		return -EINVAL;
>-	}
>+	LOCK_TEST_WITH_RETURN( dev, filp ); 
> 
> 	/* GH: Someone's doing nasty things... */
> 	if (!dev->dev_private) {
>@@ -1406,10 +1397,7 @@
>    
> 	DRM_DEBUG("i830_swap_bufs\n");
> 
>-   	if(!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
>-		DRM_ERROR("i830_swap_buf called without lock held\n");
>-		return -EINVAL;
>-	}
>+	LOCK_TEST_WITH_RETURN( dev, filp ); 
> 
> 	i830_dma_dispatch_swap( dev );
>    	return 0;
>@@ -1450,10 +1438,7 @@
> 
> 	DRM_DEBUG("%s\n", __FUNCTION__);
> 
>-   	if(!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
>-		DRM_ERROR("i830_flip_buf called without lock held\n");
>-		return -EINVAL;
>-	}
>+	LOCK_TEST_WITH_RETURN( dev, filp ); 
> 
> 	if (!dev_priv->page_flipping) 
> 		i830_do_init_pageflip( dev );
>@@ -1492,10 +1477,7 @@
>    	if (copy_from_user(&d, (drm_i830_dma_t __user *)arg, sizeof(d)))
> 		return -EFAULT;
>    
>-	if(!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
>-		DRM_ERROR("i830_dma called without lock held\n");
>-		return -EINVAL;
>-	}
>+	LOCK_TEST_WITH_RETURN( dev, filp ); 
> 	
> 	d.granted = 0;
> 
>diff -u -r ../drm.orig/i830_irq.c ./i830_irq.c
>--- ../drm.orig/i830_irq.c	2004-11-09 11:23:50.009475894 +0100
>+++ ./i830_irq.c	2004-11-09 11:31:42.503404409 +0100
>@@ -130,10 +130,7 @@
> 	drm_i830_irq_emit_t emit;
> 	int result;
> 
>-   	if(!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
>-		DRM_ERROR("i830_irq_emit called without lock held\n");
>-		return -EINVAL;
>-	}
>+	LOCK_TEST_WITH_RETURN( dev, filp ); 
> 
> 	if ( !dev_priv ) {
> 		DRM_ERROR( "%s called with no initialization\n", __FUNCTION__ );
>diff -u -r ../drm.orig/i915_dma.c ./i915_dma.c
>--- ../drm.orig/i915_dma.c	2004-11-09 11:23:50.011475555 +0100
>+++ ./i915_dma.c	2004-11-09 11:32:50.694850449 +0100
>@@ -572,10 +572,7 @@
> {
> 	DRM_DEVICE;
> 
>-   	if(!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
>-		DRM_ERROR("i915_flush_ioctl called without lock held\n");
>-		return DRM_ERR(EINVAL);
>-	}
>+	LOCK_TEST_WITH_RETURN( dev, filp ); 
> 
>     	return i915_quiescent(dev); 
> }
>@@ -601,11 +598,7 @@
> 	DRM_DEBUG("i915 batchbuffer, start %x used %d cliprects %d\n",
> 		  batch.start, batch.used, batch.num_cliprects);
> 
>-
>-   	if(!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
>-		DRM_ERROR("i915_batchbuffer called without lock held\n");
>-		return DRM_ERR(EINVAL);
>-	}
>+	LOCK_TEST_WITH_RETURN( dev, filp ); 
> 
> 	if (batch.num_cliprects && DRM_VERIFYAREA_READ(batch.cliprects, 
> 						       batch.num_cliprects *
>@@ -634,11 +627,7 @@
> 	DRM_DEBUG("i915 cmdbuffer, buf %p sz %d cliprects %d\n",
> 		  cmdbuf.buf, cmdbuf.sz, cmdbuf.num_cliprects);
> 
>-
>-   	if(!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
>-		DRM_ERROR("i915_cmdbuffer called without lock held\n");
>-		return DRM_ERR(EINVAL);
>-	}
>+	LOCK_TEST_WITH_RETURN( dev, filp ); 
> 
> 	if (cmdbuf.num_cliprects && 
> 	    DRM_VERIFYAREA_READ(cmdbuf.cliprects, 
>@@ -676,10 +665,7 @@
> 	DRM_DEVICE;
> 
> 	DRM_DEBUG("%s\n", __FUNCTION__);
>-   	if(!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
>-		DRM_ERROR("i915_flip_buf called without lock held\n");
>-		return DRM_ERR(EINVAL);
>-	}
>+	LOCK_TEST_WITH_RETURN( dev, filp ); 
> 
> 	return i915_dispatch_flip( dev );
> }
>diff -u -r ../drm.orig/i915_irq.c ./i915_irq.c
>--- ../drm.orig/i915_irq.c	2004-11-09 11:23:50.012475386 +0100
>+++ ./i915_irq.c	2004-11-09 11:33:53.411224615 +0100
>@@ -98,10 +98,7 @@
> 	drm_i915_irq_emit_t emit;
> 	int result;
> 
>-   	if(!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
>-		DRM_ERROR("i915_irq_emit called without lock held\n");
>-		return DRM_ERR(EINVAL);
>-	}
>+	LOCK_TEST_WITH_RETURN( dev, filp ); 
> 
> 	if ( !dev_priv ) {
> 		DRM_ERROR( "%s called with no initialization\n", __FUNCTION__ );

Actions: View | Splinter Review

Attachments on bug 1803: 1250

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.