Attachment 125182 Details for Bug 97010 – Patch 2/2

Patch 2/2

0002-build-don-t-disable-the-aliasing-checks.patch (text/plain), 1.19 KB, created by Lubomir Rintel on 2016-07-20 18:00:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lubomir Rintel

Created: 2016-07-20 18:00:24 UTC

Size: 1.19 KB

patch

obsolete

>From db9f97797633b54f8e48c0d8a3671761eedbbb79 Mon Sep 17 00:00:00 2001
>From: Lubomir Rintel <lkundrak@v3.sk>
>Date: Wed, 20 Jul 2016 19:55:20 +0200
>Subject: [PATCH 2/2] build: don't disable the aliasing checks
>
>We now don't break the strict aliasing rules.
>
>Also, having a compiler flag that disables a warning among the flags that are
>meant to add extra sanity checking is not correct either:
>--enable-extra-warnings=no would generate a bad aliasin warning while
>the --enable-extra-warnings=yes would not.
>---
> m4/compiler_warnings.m4 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/m4/compiler_warnings.m4 b/m4/compiler_warnings.m4
>index c592eb9..abc2da7 100644
>--- a/m4/compiler_warnings.m4
>+++ b/m4/compiler_warnings.m4
>@@ -10,7 +10,7 @@ if test "$GCC" = "yes" -a "$set_more_warnings" != "no"; then
> 	for option in -Wmissing-declarations -Wmissing-prototypes \
> 		      -Wdeclaration-after-statement -Wstrict-prototypes \
> 		      -Wno-unused-parameter -Wno-sign-compare \
>-		      -fno-strict-aliasing -Wno-deprecated-declarations \
>+		      -Wno-deprecated-declarations \
> 		      -Wno-unused-but-set-variable -Wformat-security; do
> 		SAVE_CFLAGS="$CFLAGS"
> 		CFLAGS="$CFLAGS $option"
>-- 
>2.7.4
>

Actions: View

Attachments on bug 97010: 125181 | 125182

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.