Attachment 125283 Details for Bug 36653 – [PATCH 1/2] qt4: fix memory leaks in Document::modificationDate() and Document::creationDate()

[patch] [PATCH 1/2] qt4: fix memory leaks in Document::modificationDate() and Document::creationDate()

0001-qt4-fix-memory-leaks-in-Document-modificationDate-an.patch (text/plain), 1.16 KB, created by Jakub Alba on 2016-07-24 11:48:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jakub Alba

Created: 2016-07-24 11:48:02 UTC

Size: 1.16 KB

patch

obsolete

>From 1ee2f09da077ca46fec6c70c7f17c0b4c6087d20 Mon Sep 17 00:00:00 2001
>From: Jakub Kucharski <jakubkucharski97@gmail.com>
>Date: Sun, 24 Jul 2016 13:14:19 +0200
>Subject: [PATCH 1/2] qt4: fix memory leaks in Document::modificationDate() and
> Document::creationDate()
>
>---
> qt4/src/poppler-document.cc | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/qt4/src/poppler-document.cc b/qt4/src/poppler-document.cc
>index 2893625..93f9a0a 100644
>--- a/qt4/src/poppler-document.cc
>+++ b/qt4/src/poppler-document.cc
>@@ -483,7 +483,8 @@ namespace Poppler {
> 	    return QDateTime();
> 	}
> 
>-	QString str = UnicodeParsedString(m_doc->doc->getDocInfoCreatDate());
>+	QScopedPointer<GooString> goo(m_doc->doc->getDocInfoCreatDate());
>+	QString str = UnicodeParsedString(goo.data());
> 	return Poppler::convertDate(str.toLatin1().data());
>     }
> 
>@@ -503,7 +504,8 @@ namespace Poppler {
> 	    return QDateTime();
> 	}
> 
>-	QString str = UnicodeParsedString(m_doc->doc->getDocInfoModDate());
>+	QScopedPointer<GooString> goo(m_doc->doc->getDocInfoModDate());
>+	QString str = UnicodeParsedString(goo.data());
> 	return Poppler::convertDate(str.toLatin1().data());
>     }
> 
>-- 
>2.9.0
>

Actions: View | Splinter Review

Attachments on bug 36653: 46136 | 107206 | 107317 | 107369 | 121375 | 121377 | 121427 | 121601 | 121602 | 121766 | 121929 | 124457 | 124458 | 124459 | 124460 | 124461 | 124462 | 124463 | 124569 | 124570 | 124572 | 124573 | 125116 | 125283 | 125284

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.