Attachment 125300 Details for Bug 97068 – [PATCH 2/2] init new file identifier object as a hex string

[patch] [PATCH 2/2] init new file identifier object as a hex string

0002-init-new-file-identifier-object-as-a-hex-string.patch (text/plain), 1.21 KB, created by Jakub Alba on 2016-07-24 21:16:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jakub Alba

Created: 2016-07-24 21:16:37 UTC

Size: 1.21 KB

patch

obsolete

>From f9c369a93f09c26568b0cea033aebacc886f5266 Mon Sep 17 00:00:00 2001
>From: Jakub Kucharski <jakubkucharski97@gmail.com>
>Date: Sun, 24 Jul 2016 22:46:23 +0200
>Subject: [PATCH 2/2] init new file identifier object as a hex string
>
>---
> poppler/PDFDoc.cc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/poppler/PDFDoc.cc b/poppler/PDFDoc.cc
>index f49e45a..264f83b 100644
>--- a/poppler/PDFDoc.cc
>+++ b/poppler/PDFDoc.cc
>@@ -1458,7 +1458,7 @@ Dict *PDFDoc::createTrailerDict(int uxrefSize, GBool incrUpdate, Goffset startxR
>   //calculate md5 digest
>   Guchar digest[16];
>   md5((Guchar*)message.getCString(), message.getLength(), digest);
>-  obj1.initString(new GooString((const char*)digest, 16));
>+  obj1.initHexString(new GooString((const char*)digest, 16));
> 
>   //create ID array
>   Object obj2,obj3,obj5;
>@@ -1483,7 +1483,7 @@ Dict *PDFDoc::createTrailerDict(int uxrefSize, GBool incrUpdate, Goffset startxR
>   } else {
>     //new file => same values for the two identifiers
>     obj2.arrayAdd(&obj1);
>-    obj1.initString(new GooString((const char*)digest, 16));
>+    obj1.initHexString(new GooString((const char*)digest, 16));
>     obj2.arrayAdd(&obj1);
>     trailerDict->set("ID", &obj2);
>   }
>-- 
>2.9.0
>

Actions: View | Splinter Review

Attachments on bug 97068: 125297 | 125298 | 125299 | 125300 | 125301 | 125343 | 125439 | 125440 | 125498 | 127476 | 127477

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.