Attachment 125478 Details for Bug 94249 – Make sure the second argument to container_of() is initialized

[patch] Make sure the second argument to container_of() is initialized

0001-Make-sure-the-second-argument-to-container_of-is-ini.patch (text/plain), 2.73 KB, created by Michel Dänzer on 2016-08-02 09:49:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michel Dänzer

Created: 2016-08-02 09:49:29 UTC

Size: 2.73 KB

patch

obsolete

>From 54a9ad947b1cf1fca7e96e370f2457eba4eef4ac Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Michel=20D=C3=A4nzer?= <michel.daenzer@amd.com>
>Date: Tue, 2 Aug 2016 18:47:45 +0900
>Subject: [PATCH libdrm] Make sure the second argument to container_of() is
> initialized
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Fixes warnings and miscompilation resulting in crashes with clang.
>---
> amdgpu/amdgpu_vamgr.c |  2 +-
> util_double_list.h    | 10 +++++-----
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/amdgpu/amdgpu_vamgr.c b/amdgpu/amdgpu_vamgr.c
>index 8a707cb..3eaef70 100644
>--- a/amdgpu/amdgpu_vamgr.c
>+++ b/amdgpu/amdgpu_vamgr.c
>@@ -157,7 +157,7 @@ amdgpu_vamgr_find_va(struct amdgpu_bo_va_mgr *mgr, uint64_t size,
> drm_private void
> amdgpu_vamgr_free_va(struct amdgpu_bo_va_mgr *mgr, uint64_t va, uint64_t size)
> {
>-	struct amdgpu_bo_va_hole *hole;
>+	struct amdgpu_bo_va_hole *hole = NULL;
> 
> 	if (va == AMDGPU_INVALID_VA_ADDRESS)
> 		return;
>diff --git a/util_double_list.h b/util_double_list.h
>index 5d01f52..e0e49b8 100644
>--- a/util_double_list.h
>+++ b/util_double_list.h
>@@ -114,29 +114,29 @@ static inline void list_delinit(struct list_head *item)
> #endif
> 
> #define LIST_FOR_EACH_ENTRY(pos, head, member)				\
>-   for (pos = container_of((head)->next, pos, member);			\
>+   for (pos = NULL, pos = container_of((head)->next, pos, member);	\
> 	&pos->member != (head);						\
> 	pos = container_of(pos->member.next, pos, member))
> 
> #define LIST_FOR_EACH_ENTRY_SAFE(pos, storage, head, member)	\
>-   for (pos = container_of((head)->next, pos, member),			\
>+   for (pos = NULL, pos = container_of((head)->next, pos, member),			\
> 	storage = container_of(pos->member.next, pos, member);	\
> 	&pos->member != (head);						\
> 	pos = storage, storage = container_of(storage->member.next, storage, member))
> 
> #define LIST_FOR_EACH_ENTRY_SAFE_REV(pos, storage, head, member)	\
>-   for (pos = container_of((head)->prev, pos, member),			\
>+   for (pos = NULL, pos = container_of((head)->prev, pos, member),			\
> 	storage = container_of(pos->member.prev, pos, member);		\
> 	&pos->member != (head);						\
> 	pos = storage, storage = container_of(storage->member.prev, storage, member))
> 
> #define LIST_FOR_EACH_ENTRY_FROM(pos, start, head, member)		\
>-   for (pos = container_of((start), pos, member);			\
>+   for (pos = NULL, pos = container_of((start), pos, member);			\
> 	&pos->member != (head);						\
> 	pos = container_of(pos->member.next, pos, member))
> 
> #define LIST_FOR_EACH_ENTRY_FROM_REV(pos, start, head, member)		\
>-   for (pos = container_of((start), pos, member);			\
>+   for (pos = NULL, pos = container_of((start), pos, member);			\
> 	&pos->member != (head);						\
> 	pos = container_of(pos->member.prev, pos, member))
> 
>-- 
>2.8.1
>

Actions: View | Splinter Review

Attachments on bug 94249: 125417 | 125418 | 125419 | 125420 | 125437 | 125478

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.