Attachment 126010 Details for Bug 97460 – workaround

[patch] workaround

0001-drm-amdgpu-avoid-a-possible-array-overflow.patch (text/plain), 1.24 KB, created by Alex Deucher on 2016-08-24 16:50:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2016-08-24 16:50:49 UTC

Size: 1.24 KB

patch

obsolete

>From 92e373d93f0f1560ae7ef2c69a98f68658a813ef Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexander.deucher@amd.com>
>Date: Wed, 24 Aug 2016 12:31:36 -0400
>Subject: [PATCH] drm/amdgpu: avoid a possible array overflow
>
>When looking up the connector type make sure the index
>is valid.  Avoids a later crash if we read past the end
>of the array.
>
>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>Cc: stable@vger.kernel.org
>---
> drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
>index 9831753..1514223 100644
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
>@@ -321,6 +321,12 @@ bool amdgpu_atombios_get_connector_info_from_object_table(struct amdgpu_device *
> 			    (le16_to_cpu(path->usConnObjectId) &
> 			     OBJECT_TYPE_MASK) >> OBJECT_TYPE_SHIFT;
> 
>+			if (con_obj_id >= ARRAY_SIZE(object_connector_convert)) {
>+				DRM_ERROR("invalid con_obj_id %d for device tag 0x%04x\n",
>+					  con_obj_id, le16_to_cpu(path->usDeviceTag));
>+				continue;
>+			}
>+
> 			connector_type =
> 				object_connector_convert[con_obj_id];
> 			connector_object_id = con_obj_id;
>-- 
>2.5.5
>

Actions: View | Splinter Review

Attachments on bug 97460: 125990 | 126010 | 126011

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.