Attachment 126167 Details for Bug 94477 – patch to reduce time spent

[patch] patch to reduce time spent

0001-glsl-use-div_visitor-to-simplify-div-expressions.patch (text/plain), 2.54 KB, created by Tapani Pälli on 2016-09-02 07:34:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tapani Pälli

Created: 2016-09-02 07:34:37 UTC

Size: 2.54 KB

patch

obsolete

>From fa817ca35b1b6498d5c24b2bc2d12d4ba972ee34 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Tapani=20P=C3=A4lli?= <tapani.palli@intel.com>
>Date: Fri, 2 Sep 2016 09:35:49 +0300
>Subject: [PATCH] glsl: use div_visitor to simplify div expressions
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This simply replaces div(a, b) to 1 if a equals to b. Reduces
>time spent with WebGL test 'temp-expressions-should-not-crash'. Time
>spent in bug 94477 test case goes down to ~70 secs from ~580 secs on
>my HSW machine.
>
>Signed-off-by: Tapani PÃ¤lli <tapani.palli@intel.com>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94477
>---
> src/compiler/glsl/opt_copy_propagation.cpp | 57 +++++++++++++++++++++++++++++-
> 1 file changed, 56 insertions(+), 1 deletion(-)
>
>diff --git a/src/compiler/glsl/opt_copy_propagation.cpp b/src/compiler/glsl/opt_copy_propagation.cpp
>index 443905d..31dd42a 100644
>--- a/src/compiler/glsl/opt_copy_propagation.cpp
>+++ b/src/compiler/glsl/opt_copy_propagation.cpp
>@@ -34,12 +34,64 @@
> 
> #include "ir.h"
> #include "ir_visitor.h"
>+#include "ir_rvalue_visitor.h"
> #include "ir_basic_block.h"
> #include "ir_optimization.h"
> #include "compiler/glsl_types.h"
> 
> namespace {
> 
>+class div_visitor : public ir_rvalue_visitor {
>+public:
>+   div_visitor(exec_list *insts)
>+   {
>+      instructions = insts;
>+      progress = false;
>+   }
>+
>+   bool run()
>+   {
>+      visit_list_elements(this, instructions);
>+      return progress;
>+   }
>+
>+   void handle_rvalue(ir_rvalue **rvalue);
>+
>+private:
>+   exec_list *instructions;
>+   bool progress;
>+};
>+
>+void
>+div_visitor::handle_rvalue(ir_rvalue **rvalue)
>+{
>+   if (!*rvalue)
>+      return;
>+
>+   ir_rvalue *ir = *rvalue;
>+   ir_expression *expr = (*rvalue)->as_expression();
>+
>+   /* interested only in ir_binop_div */
>+   if (expr == NULL || expr->operation != ir_binop_div)
>+      return;
>+
>+   ir_dereference_variable *a = expr->operands[0]->as_dereference_variable();
>+   ir_dereference_variable *b = expr->operands[1]->as_dereference_variable();
>+
>+   if (!a || !b)
>+      return;
>+
>+   if (!a->equals(b))
>+      return;
>+
>+   /* simplify if div(a, b) and a equals b .. */
>+   *rvalue = new(ralloc_parent(ir)) ir_constant(1);
>+
>+   progress = true;
>+}
>+
>+
>+
> class acp_entry : public exec_node
> {
> public:
>@@ -366,7 +418,10 @@ do_copy_propagation(exec_list *instructions)
> {
>    ir_copy_propagation_visitor v;
> 
>+   div_visitor div_v(instructions);
>+   bool div_res = div_v.run();
>+
>    visit_list_elements(&v, instructions);
> 
>-   return v.progress;
>+   return v.progress || div_res;
> }
>-- 
>2.7.4
>

Actions: View | Splinter Review

Attachments on bug 94477: 122206 | 126167 | 126170 | 126236 | 126539

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.